From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 554E81FF15E for ; Mon, 24 Nov 2025 10:40:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B7891D1D8; Mon, 24 Nov 2025 10:41:08 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 24 Nov 2025 10:40:14 +0100 Message-ID: <20251124094018.224661-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763977200177 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" These patches fix an issue with garbage collection on S3 backends for an edge case where the local chunk marker is missing and the chunk not being referenced anymore by any index file. In that case garbage collection failed when trying to remove the missing marker from the local datastore cache. Fix this by adapting the phase 2 logic such that the atime is now optional, skipping over the chunk sweep logic if not set and adding the chunk directly for deletion. The followup patches improve docstrings and method names to be more telling and reduce code duplication. Changes since version 1 (thanks @ Thomas and Fabian for feedback): - Instead of creating the marker just for it to be deleted again, skip over the whole atime check logic in this case - Fix and extend docs and method names Christian Ebner (4): GC: s3: fix local marker cleanup for unreferenced, s3 only chunks chunk store: fix and expand the clear_chunk_expected_mark() docstring chunk store: clarify chunk marker helper creates marker if missing datastore: refactor common delete list logic into closure pbs-datastore/src/chunk_store.rs | 15 +++- pbs-datastore/src/datastore.rs | 88 ++++++++++++------- .../src/local_datastore_lru_cache.rs | 10 ++- 3 files changed, 77 insertions(+), 36 deletions(-) -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel