From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DBE3D1FF184 for ; Thu, 20 Nov 2025 15:51:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF99CB963; Thu, 20 Nov 2025 15:51:05 +0100 (CET) From: Stefan Hanreich To: pbs-devel@lists.proxmox.com Date: Thu, 20 Nov 2025 15:50:11 +0100 Message-ID: <20251120145031.550340-4-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120145031.550340-1-s.hanreich@proxmox.com> References: <20251120145031.550340-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.173 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox 3/5] proxmox-fixed-string: implement hash trait X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Some enums in pbs-api-types implement Hash, so FixedString needs to implement it too in order to be usable there. While it should have been fine to use the whole struct here because the buffer is zeroed on construction and the length is constant for equal strings - still only use the actual bytes from the buffer that contain the current string to avoid potential shenanigans. Signed-off-by: Stefan Hanreich --- proxmox-fixed-string/src/lib.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/proxmox-fixed-string/src/lib.rs b/proxmox-fixed-string/src/lib.rs index e70e1327..aa3fca2b 100644 --- a/proxmox-fixed-string/src/lib.rs +++ b/proxmox-fixed-string/src/lib.rs @@ -2,6 +2,7 @@ use std::borrow::Borrow; use std::cmp::Ordering; use std::error::Error; use std::fmt; +use std::hash::{Hash, Hasher}; use std::ops::Deref; use std::str::FromStr; @@ -154,6 +155,12 @@ impl Borrow for FixedString { } } +impl Hash for FixedString { + fn hash(&self, state: &mut H) { + self.as_bytes().hash(state); + } +} + impl TryFrom for FixedString { type Error = TooLongError; -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel