From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8F6F91FF184 for ; Thu, 20 Nov 2025 15:50:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26F7BB928; Thu, 20 Nov 2025 15:51:05 +0100 (CET) From: Stefan Hanreich To: pbs-devel@lists.proxmox.com Date: Thu, 20 Nov 2025 15:50:09 +0100 Message-ID: <20251120145031.550340-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120145031.550340-1-s.hanreich@proxmox.com> References: <20251120145031.550340-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.173 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" old_version was changed to be an Option in proxmox-apt-api-types, so handle that here as well. Signed-off-by: Stefan Hanreich --- Not 100% sure about how to handle the case of a missing old_version. Could you please take a look @Shannon? proxmox-upgrade-checks/src/lib.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/proxmox-upgrade-checks/src/lib.rs b/proxmox-upgrade-checks/src/lib.rs index 4f76555a..207af04b 100644 --- a/proxmox-upgrade-checks/src/lib.rs +++ b/proxmox-upgrade-checks/src/lib.rs @@ -204,7 +204,13 @@ impl UpgradeChecker { if let Some(meta_pkg) = meta_pkg { let pkg_version = Regex::new(r"^(\d+)\.(\d+)[.-](\d+)")?; - let captures = pkg_version.captures(&meta_pkg.old_version); + + let captures = meta_pkg + .old_version + .as_ref() + .map(|old_version| pkg_version.captures(old_version)) + .flatten(); + if let Some(captures) = captures { let maj = Self::extract_version_from_captures(1, &captures)?; let min = Self::extract_version_from_captures(2, &captures)?; -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel