From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A392F1FF184 for ; Thu, 20 Nov 2025 15:32:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C11EB346; Thu, 20 Nov 2025 15:32:47 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 20 Nov 2025 15:31:49 +0100 Message-ID: <20251120143149.480899-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763649101080 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [service.in, proxy.pid] Subject: [pbs-devel] [PATCH proxmox-backup v3] etc: raise nofile soft limit to hard limit for proxmox-backup-proxy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Since commit 86d5d073 ("GC: fix race with chunk upload/insert on s3 backends"), per-chunk file locks are acquired during phase 2 of garbage collection for datastores backed by s3 object stores. This however means that up to 1000 file locks might be held at once, which can result in the limit of open file handles to be reached. Therefore, bump the NOFILE soft limit for the proxmox-backup-proxy in the systemd service unit, while keeping the hard limit as defined in /etc/systemd/system.conf. This is acceptable since PBS does not directly depend on problematic select() calls as verified via `nm` and does not use it in linked libraries to the best of my knowledge. Occurrences of the symbol according to `nm -D ` are: /lib/x86_64-linux-gnu/libapt-pkg.so.7.0 U select@GLIBC_2.2.5 /lib/x86_64-linux-gnu/libpam.so.0 U select@GLIBC_2.2.5 /lib/x86_64-linux-gnu/libc.so.6 000000000010e140 W select@@GLIBC_2.2.5 /lib/x86_64-linux-gnu/libcrypto.so.3 U select@GLIBC_2.2.5 [0] https://github.com/systemd/systemd/blob/main/NEWS#L12044 Signed-off-by: Christian Ebner --- Changes since version 2: - But soft to hard limit - Extend commit message with respect to select() etc/proxmox-backup-proxy.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/etc/proxmox-backup-proxy.service.in b/etc/proxmox-backup-proxy.service.in index 7ca806aa4..8e4bbc197 100644 --- a/etc/proxmox-backup-proxy.service.in +++ b/etc/proxmox-backup-proxy.service.in @@ -10,6 +10,7 @@ Type=notify ExecStart=%LIBEXECDIR%/proxmox-backup/proxmox-backup-proxy ExecReload=/bin/kill -HUP $MAINPID PIDFile=/run/proxmox-backup/proxy.pid +LimitNOFILE=524288 Restart=on-failure User=%PROXY_USER% Group=%PROXY_USER% -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel