From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 85A5D1FF183 for ; Wed, 19 Nov 2025 10:26:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2A91158D; Wed, 19 Nov 2025 10:26:37 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 19 Nov 2025 10:25:59 +0100 Message-ID: <20251119092634.763388-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager master+stable-8] pve8to9: improve error/log message for tls checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" we check different key sizes for RSA (2048) vs ECC (224) but the logs/error always wrote '2048' which can be confusing if ECC keys are used, for example: PASS: Certificate 'pveproxy-ssl.pem' passed Debian Busters (and newer) security level for TLS connections (256 >= 2048) Use the actual size and type we check against in the log/error so reduce confusion. The new log line is then: PASS: Certificate 'pveproxy-ssl.pem' passed Debian Busters (and newer) security level for TLS connections (256 >= 224 ECC) Signed-off-by: Dominik Csapak --- this is based on master, but should be cleanly cherry-pickable on stable-8 currently PVE/CLI/pve8to9.pm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 5a22c229..0c4b2343 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -2257,12 +2257,16 @@ sub check_misc { next; } - if ($size < $check->{minsize}) { - log_fail("'$fn', certificate's $check->{name} public key size is less than 2048 bit"); + my $min_size = $check->{minsize}; + my $name = $check->{name}; + if ($size < $min_size) { + log_fail( + "'$fn', certificate's $check->{name} public key size is less than $min_size bit for $name" + ); $certs_check_failed = 1; } else { log_pass( - "Certificate '$fn' passed Debian Busters (and newer) security level for TLS connections ($size >= 2048)" + "Certificate '$fn' passed Debian Busters (and newer) security level for TLS connections ($size >= $min_size $name)" ); } } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel