From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 37CC91FF187 for ; Tue, 18 Nov 2025 14:54:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C19C215A1D; Tue, 18 Nov 2025 14:54:55 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Tue, 18 Nov 2025 14:54:45 +0100 Message-ID: <20251118135447.337323-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763474062471 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH network] api: sdn: fix null vmid for tap/veth ports on bridges api call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When using an interface without a firewall on a VM or container, it results in tapi or vethi bridge ports. Previously, a single regex with multiple options caused incorrect capture group variables, $1 and $2 would always refer to the first group (fwpr) even if we matched on e.g. `veth`. Split into separate matches. Signed-off-by: Gabriel Goller Reported-by: Friedrich Weber --- src/PVE/API2/Network/SDN/Nodes/Zone.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/Network/SDN/Nodes/Zone.pm b/src/PVE/API2/Network/SDN/Nodes/Zone.pm index f86ad1ead271..c1e48da70dd1 100644 --- a/src/PVE/API2/Network/SDN/Nodes/Zone.pm +++ b/src/PVE/API2/Network/SDN/Nodes/Zone.pm @@ -269,7 +269,13 @@ __PACKAGE__->register_method({ name => $ifname, }; - if ($ifname =~ m/^(?:fwpr(\d+)p(\d+)|veth(\d+)i(\d+)|tap(\d+)i(\d+))$/) { + if ($ifname =~ m/^fwpr(\d+)p(\d+)$/) { + $port->{vmid} = $1; + $port->{index} = "net$2"; + } elsif ($ifname =~ m/^veth(\d+)i(\d+)$/) { + $port->{vmid} = $1; + $port->{index} = "net$2"; + } elsif ($ifname =~ m/^tap(\d+)i(\d+)$/) { $port->{vmid} = $1; $port->{index} = "net$2"; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel