From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7E7D61FF187 for ; Tue, 18 Nov 2025 13:35:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F6C513547; Tue, 18 Nov 2025 13:35:23 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 18 Nov 2025 13:34:41 +0100 Message-ID: <20251118123516.112546-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251118123516.112546-1-f.ebner@proxmox.com> References: <20251118123516.112546-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763469290418 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ovmf.pm] Subject: [pve-devel] [PATCH qemu-server 3/4] ovmf: factor out helper for checking whether MS 2023 certificate should be enrolled X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In preparation to only call that helper during VM start. See the following commit "vm start: ovmf: do not auto-enroll Microsoft UEFI CA 2023" for details. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/OVMF.pm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/OVMF.pm b/src/PVE/QemuServer/OVMF.pm index 409ad022..e5f4cf02 100644 --- a/src/PVE/QemuServer/OVMF.pm +++ b/src/PVE/QemuServer/OVMF.pm @@ -278,13 +278,23 @@ sub print_ovmf_commandline { return ($cmd, $machine_flags); } -sub ensure_ms_2023_cert_enrolled { - my ($storecfg, $vmid, $efidisk_str) = @_; +sub should_enroll_ms_2023_cert { + my ($efidisk_str) = @_; my $efidisk = parse_drive('efidisk0', $efidisk_str); return if !$efidisk->{'pre-enrolled-keys'}; return if $efidisk->{'ms-cert'} && $efidisk->{'ms-cert'} eq '2023'; + return 1; +} + +sub ensure_ms_2023_cert_enrolled { + my ($storecfg, $vmid, $efidisk_str) = @_; + + return if !should_enroll_ms_2023_cert($efidisk_str); + + my $efidisk = parse_drive('efidisk0', $efidisk_str); + print "efidisk0: enrolling Microsoft UEFI CA 2023\n"; my $qsd_id = "vm-$vmid-efi-enroll"; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel