From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B99351FF185 for ; Mon, 17 Nov 2025 18:22:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3125E40; Mon, 17 Nov 2025 18:21:54 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 18:21:04 +0100 Message-ID: <20251117172147.533969-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251117172147.533969-1-d.kral@proxmox.com> References: <20251117172147.533969-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763400081514 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 5/7] sim: hardware: do not print stat changes in set_static_service_stats X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Using the command is already enough to document the changes and printing to stdout will not document these changes anyway. Also will throw a uninitialized value comparison warning for new HA resources, which do not have any static service stat value set. Signed-off-by: Daniel Kral --- src/PVE/HA/Sim/Hardware.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index a1381b78..baee2018 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -187,12 +187,10 @@ sub set_static_service_stats { my $stats = $self->read_static_service_stats(); if (my $memory = $new_stats->{maxmem}) { - print "setting $sid memory to $memory\n" if $memory != $stats->{$sid}->{maxmem}; $stats->{$sid}->{maxmem} = $memory; } if (my $cpu = $new_stats->{maxcpu}) { - print "setting $sid memory to $cpu\n" if $cpu != $stats->{$sid}->{maxcpu}; $stats->{$sid}->{maxcpu} = $cpu; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel