From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 07C021FF185 for ; Mon, 17 Nov 2025 16:35:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45CA01E02F; Mon, 17 Nov 2025 16:35:23 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 16:35:10 +0100 Message-ID: <20251117153509.390137-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763393690744 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager] remote tasks: correctly filter out foreign running PBS tasks X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" At the moment, only tasks started by PDM will ever show up as 'active' - mostly to avoid having to regularly poll foreign (as in, not started by PDM) tasks. If we included running tasks in the task cache, they could appear as 'stuck' for up to one poll interval, even if they ran only for a couple of seconds. This commit fixes a mistake when checking whether the task is still running or not. Before, we *only* included running tasks, which is the opposite of what we want. Signed-off-by: Lukas Wagner --- server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs index 92f0f241..d3c8395e 100644 --- a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs +++ b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs @@ -301,7 +301,7 @@ async fn fetch_tasks_from_single_node( .await? .into_iter() .filter_map(|task| { - if task.endtime.is_none() { + if task.endtime.is_some() { // We only care about finished tasks. Some(map_pbs_task(task, remote.id.clone())) } else { -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel