From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F95C1FF185 for ; Mon, 17 Nov 2025 11:49:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05EC314486; Mon, 17 Nov 2025 11:49:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1763376531; x=1763981331; d=canarybit.eu; s=rsa1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:from; bh=5acsxEg+jF9uT07VpBDVUAhBdyt9cHxD6QvAthUjMvU=; b=QjBFtdPLz1zR48lPeuzkd/d04qIo4Gs3JV/rLgT9ahpYQbORC84T8Vm7nxHnzQvWWkUEyIEDia36k mv8A1DMdCFmANqronffv6gHSSMGcs3KSRNDrwjlAaRB2HQGGS+pS/GeRYXO/l5vj5fEf8FqfGCq+eg 87rAqwvr/M6SC5RtrNZJNpgQZsE0VHOPGcr9ROwo1kj1YPJ/iCUTTAocxHMRk3hvMP/2hLPY/aU491 tw1dZ8wrlXlqTXkQrtRweWgCpoc2ucWhtHKyXIAiU7fzS0gQs3/er7rPRvsdf292dhnxwa6xJnR+da tC5rRIEbyH7GFphkoKmIdApWiZsXeSQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1763376531; x=1763981331; d=canarybit.eu; s=ed1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:from; bh=5acsxEg+jF9uT07VpBDVUAhBdyt9cHxD6QvAthUjMvU=; b=jMSnJsU2si70kP4TibFtLX8UYbOPBNyNal1ZsGfv7mcGdqZtyytaFLKf8/xWwx3Q2JaYFHLJKqz3W J6CW1feCA== X-HalOne-ID: 00e8263b-c3a3-11f0-a47c-c9fa7b04d629 From: Anton Iacobaeus To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 11:48:00 +0100 Message-ID: <20251117104817.471815-3-anton.iacobaeus@canarybit.eu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117104817.471815-1-anton.iacobaeus@canarybit.eu> References: <20251117104817.471815-1-anton.iacobaeus@canarybit.eu> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.691 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_MISSING 0.1 Missing DMARC policy MIME_BASE64_TEXT 1.741 Message text disguised using base64 encoding RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH qemu-server 1/1] Add support for TDX quote-generation-socket object X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Extend the tdx object with the quote-generation-socket as defined in: https://www.qemu.org/docs/master/interop/qemu-storage-daemon-qmp-ref.html#object-QSD-qom.TdxGuestProperties Only vsock is included here since it is the most commonly used with TDX attestation. Signed-off-by: Anton Iacobaeus --- src/PVE/QemuServer.pm | 3 +- src/PVE/QemuServer/CPUConfig.pm | 60 +++++++++++++++++++++++++++++++-- 2 files changed, 60 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index ddd30abb..11c7543f 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -3794,7 +3794,8 @@ sub config_to_command { push @$devices, '-object', get_amd_sev_object($conf->{'amd-sev'}, $conf->{bios}); push @$machineFlags, 'confidential-guest-support=sev0'; } elsif ($conf->{'intel-tdx'}) { - push @$devices, '-object', get_intel_tdx_object($conf->{'intel-tdx'}, $conf->{bios}); + my $tdx_object = get_intel_tdx_object($conf->{'intel-tdx'}, $conf->{bios}); + push @$devices, '-object', to_json($tdx_object, { canonical => 1 }); push @$machineFlags, 'confidential-guest-support=tdx0'; push @$machineFlags, 'kernel_irqchip=split'; } diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm index 67b05925..dae6f379 100644 --- a/src/PVE/QemuServer/CPUConfig.pm +++ b/src/PVE/QemuServer/CPUConfig.pm @@ -5,7 +5,7 @@ use warnings; use JSON; -use PVE::JSONSchema; +use PVE::JSONSchema qw(json_bool); use PVE::Cluster qw(cfs_register_file cfs_read_file); use PVE::ProcFSTools; use PVE::RESTEnvironment qw(log_warn); @@ -348,6 +348,32 @@ my $tdx_fmt = { format_description => "tdx-type", enum => ['tdx'], }, + 'attestation' => { + description => "Enable TDX attestation by including quote-generation-socket", + type => 'boolean', + default => 1, + }, + 'socket-type' => { + type => 'string', + optional => 1, + enum => ['vsock'], + default => 'vsock', + description => "Socket type to communicate with the Quote Generation Service", + }, + 'vsock-cid' => { + type => 'integer', + minimum => 2, + default => 2, + optional => 1, + description => "CID for vsock of Quote Generation Service", + }, + 'vsock-port' => { + type => 'integer', + minimum => 0, + default => 4050, + optional => 1, + description => "Port for vsock of Quote Generation Service", + }, }; PVE::JSONSchema::register_format('pve-qemu-tdx-fmt', $tdx_fmt); @@ -1088,6 +1114,27 @@ sub get_amd_sev_object { return $sev_mem_object; } +sub get_quote_generation_socket { + my ($conf) = @_; + my $type = $conf->{'socket-type'} + or die "A socket type is required for Quote Generation Socket.\n"; + + my $socket = { + type => $type, + }; + + if ($type eq 'vsock') { + $socket->{'cid'} = $conf->{'vsock-cid'} + or die "Missing cid for vsock.\n"; + $socket->{'port'} = $conf->{'vsock-port'} + or die "Missing port for vsock.\n"; + } else { + die "Unsupported socket type for TDX Quote Generation Socket.\n"; + } + + return $socket; +} + sub get_intel_tdx_object { my ($intel_tdx, $bios) = @_; my $intel_tdx_conf = PVE::JSONSchema::parse_property_string($tdx_fmt, $intel_tdx); @@ -1099,7 +1146,16 @@ sub get_intel_tdx_object { if (!$bios || $bios ne 'ovmf') { die "To use Intel TDX, you need to change the BIOS to OVMF.\n"; } - return 'tdx-guest,id=tdx0'; + + my $tdx_object = { + 'qom-type' => 'tdx-guest', + id => 'tdx0', + }; + + $tdx_object->{'quote-generation-socket'} = get_quote_generation_socket($intel_tdx_conf) + if $intel_tdx_conf->{'attestation'}; + + return $tdx_object; } __PACKAGE__->register(); -- 2.43.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel