From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C72C01FF185 for ; Mon, 17 Nov 2025 11:33:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D6353139C1; Mon, 17 Nov 2025 11:33:45 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 11:33:19 +0100 Message-ID: <20251117103337.26032-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763375591534 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qm.pm] Subject: [pve-devel] [PATCH v2 qemu-server] qm: import: use schema variant with 'import-from' disk allocation support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the community forum [0], it was not possible to use the extended schema that supports disk allocation with 'import-from' for 'qm import'. Align it more closely to the VM creation endpoint. [0]: https://forum.proxmox.com/threads/166734/ Signed-off-by: Fiona Ebner --- Better viewed with the '-w' option for the diff. Changes in v2: * Rebase on current master. src/PVE/CLI/qm.pm | 82 +++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 39 deletions(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index 2e56e234..9398780e 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -1084,47 +1084,51 @@ __PACKAGE__->register_method({ "Import a foreign virtual guest from a supported import source, such as an ESXi storage.", parameters => { additionalProperties => 0, - properties => PVE::QemuServer::json_config_properties({ - vmid => get_standard_option( - 'pve-vmid', - { completion => \&PVE::Cluster::complete_next_vmid }, - ), - 'source' => { - type => 'string', - description => 'The import source volume id.', - }, - storage => get_standard_option( - 'pve-storage-id', - { - description => "Default storage.", - completion => \&PVE::QemuServer::complete_storage, + properties => PVE::QemuServer::json_config_properties( + { + vmid => get_standard_option( + 'pve-vmid', + { completion => \&PVE::Cluster::complete_next_vmid }, + ), + 'source' => { + type => 'string', + description => 'The import source volume id.', + }, + storage => get_standard_option( + 'pve-storage-id', + { + description => "Default storage.", + completion => \&PVE::QemuServer::complete_storage, + }, + ), + 'live-import' => { + type => 'boolean', + optional => 1, + default => 0, + description => + "Immediately start the VM and copy the data in the background.", + }, + 'dryrun' => { + type => 'boolean', + optional => 1, + default => 0, + description => "Show the create command and exit without doing anything.", + }, + delete => { + type => 'string', + format => 'pve-configid-list', + description => "A list of settings you want to delete.", + optional => 1, + }, + format => { + type => 'string', + description => 'Target format', + enum => ['raw', 'qcow2', 'vmdk'], + optional => 1, }, - ), - 'live-import' => { - type => 'boolean', - optional => 1, - default => 0, - description => "Immediately start the VM and copy the data in the background.", }, - 'dryrun' => { - type => 'boolean', - optional => 1, - default => 0, - description => "Show the create command and exit without doing anything.", - }, - delete => { - type => 'string', - format => 'pve-configid-list', - description => "A list of settings you want to delete.", - optional => 1, - }, - format => { - type => 'string', - description => 'Target format', - enum => ['raw', 'qcow2', 'vmdk'], - optional => 1, - }, - }), + 1, # with_disk_alloc + ), }, returns => { type => 'null' }, code => sub { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel