From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 03E7A1FF187 for ; Mon, 17 Nov 2025 10:21:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CAED9117BF; Mon, 17 Nov 2025 10:21:43 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 10:21:06 +0100 Message-ID: <20251117092110.628324-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: lxc options: fix rendering default and '0' value for tty count X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" if '0' was entered, the options grid would show an empty line. Fix that by adding a renderer that checks if the value is a number. If the default is set, the edit window would always pre-fill the value '2' instead of leaving the field empty. Fix that by removing the manually set 'value' property. Reported-by: Dietmar Maurer Signed-off-by: Dominik Csapak --- www/manager6/lxc/Options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 6cc2e2b4..0acb88f4 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -81,6 +81,7 @@ Ext.define('PVE.lxc.Options', { tty: { header: gettext('TTY count'), defaultValue: 2, + renderer: (value) => (Ext.isNumber(value) ? value : '2'), editor: caps.vms['VM.Config.Options'] ? { xtype: 'proxmoxWindowEdit', @@ -90,7 +91,6 @@ Ext.define('PVE.lxc.Options', { name: 'tty', minValue: 0, maxValue: 6, - value: 2, fieldLabel: gettext('TTY count'), emptyText: gettext('Default'), deleteEmpty: true, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel