From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 58D261FF17E for ; Thu, 13 Nov 2025 14:31:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 66D791C7C7; Thu, 13 Nov 2025 14:32:43 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Thu, 13 Nov 2025 14:32:07 +0100 Message-ID: <20251113133208.426106-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251113133208.426106-1-s.sterz@proxmox.com> References: <20251113133208.426106-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763040704170 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH yew-comp v5 2/2] node status panel: make power management and fingerprint buttons opt-in X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" the panel appeared to dense with all these tools being present in every situation. so make them opt-in. Signed-off-by: Shannon Sterz --- src/node_status_panel.rs | 35 +++++++++++++++++++++++++---------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/src/node_status_panel.rs b/src/node_status_panel.rs index 3d37d80..3f8946d 100644 --- a/src/node_status_panel.rs +++ b/src/node_status_panel.rs @@ -27,6 +27,14 @@ pub struct NodeStatusPanel { #[builder(IntoPropValue, into_prop_value)] #[prop_or_default] status_base_url: Option, + + #[builder(IntoPropValue, into_prop_value)] + #[prop_or_default] + fingerprint_button: bool, + + #[builder(IntoPropValue, into_prop_value)] + #[prop_or_default] + power_management_buttons: bool, } impl NodeStatusPanel { @@ -195,7 +203,7 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .as_ref() .map(|r| crate::NodeStatus::Common(r)); - Panel::new() + let mut panel = Panel::new() .border(false) .class(FlexFit) .title( @@ -206,7 +214,11 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .with_child(tr!("Node Status")) .into_html(), ) - .with_tool( + .with_child(node_info(status)) + .with_optional_child(self.error.as_ref().map(|e| error_message(&e.to_string()))); + + if ctx.props().power_management_buttons { + panel.add_tool( ConfirmButton::new(tr!("Reboot")) .confirm_message(tr!("Are you sure you want to reboot the node?")) .on_activate( @@ -214,8 +226,8 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .callback(|_| Msg::RebootOrShutdown(NodePowerCommand::Reboot)), ) .icon_class("fa fa-undo"), - ) - .with_tool( + ); + panel.add_tool( ConfirmButton::new(tr!("Shutdown")) .confirm_message(tr!("Are you sure you want to shut down the node?")) .on_activate( @@ -223,8 +235,11 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .callback(|_| Msg::RebootOrShutdown(NodePowerCommand::Shutdown)), ) .icon_class("fa fa-power-off"), - ) - .with_tool( + ); + } + + if ctx.props().fingerprint_button { + panel.add_tool( Button::new(tr!("Show Fingerprint")) .icon_class("fa fa-hashtag") .class(ColorScheme::Primary) @@ -232,10 +247,10 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { ctx.link() .change_view_callback(|_| ViewState::FingerprintDialog), ), - ) - .with_child(node_info(status)) - .with_optional_child(self.error.as_ref().map(|e| error_message(&e.to_string()))) - .into() + ); + } + + panel.into() } } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel