From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 01ED31FF179 for ; Wed, 12 Nov 2025 14:20:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5402733AC; Wed, 12 Nov 2025 14:20:54 +0100 (CET) From: Gabriel Goller To: pdm-devel@lists.proxmox.com Date: Wed, 12 Nov 2025 14:20:20 +0100 Message-ID: <20251112132045.165444-4-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112132045.165444-1-g.goller@proxmox.com> References: <20251112132045.165444-1-g.goller@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762953624953 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 3/9] ui: improve error message when controller cannot be found X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" With the added permissions, it often happens that the user has permissions to view the zone, but doesn't have permissions to view the controller. This means we can't display the zone in the EVPN overview. "not found" is a more correct error than "doesn't exist". Signed-off-by: Gabriel Goller --- ui/src/sdn/evpn/remote_tree.rs | 6 ++++-- ui/src/sdn/evpn/vrf_tree.rs | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ui/src/sdn/evpn/remote_tree.rs b/ui/src/sdn/evpn/remote_tree.rs index ee57b33c18f2..7243a03329c0 100644 --- a/ui/src/sdn/evpn/remote_tree.rs +++ b/ui/src/sdn/evpn/remote_tree.rs @@ -176,7 +176,8 @@ fn zones_to_remote_view( }) .ok_or_else(|| { anyhow!(tr!( - "Could not find Controller for EVPN zone {}", + "Controller {} of EVPN zone {} not found", + zone_controller_id, zone_data.zone )) })?; @@ -260,7 +261,8 @@ fn zones_to_remote_view( }) .ok_or_else(|| { anyhow!(tr!( - "Controller of EVPN zone {} does not exist", + "Controller {} of EVPN zone {} not found", + zone_controller_id, zone.zone.zone )) })?; diff --git a/ui/src/sdn/evpn/vrf_tree.rs b/ui/src/sdn/evpn/vrf_tree.rs index 8481dfcf6027..d690501265a9 100644 --- a/ui/src/sdn/evpn/vrf_tree.rs +++ b/ui/src/sdn/evpn/vrf_tree.rs @@ -140,7 +140,8 @@ fn zones_to_vrf_view( }) .ok_or_else(|| { anyhow!(tr!( - "Controller of EVPN zone {} does not exist", + "Controller {} of EVPN zone {} not found", + zone_controller_id, zone_data.zone )) })?; @@ -199,7 +200,8 @@ fn zones_to_vrf_view( }) .ok_or_else(|| { anyhow!(tr!( - "Controller of EVPN zone {} does not exist", + "Controller {} of EVPN zone {} not found", + zone_controller_id, zone.zone.zone )) })?; -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel