From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 11B231FF17A for ; Tue, 11 Nov 2025 14:59:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CB8AB807; Tue, 11 Nov 2025 15:00:16 +0100 (CET) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Tue, 11 Nov 2025 15:00:04 +0100 Message-ID: <20251111140005.41510-4-s.shaji@proxmox.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251111140005.41510-1-s.shaji@proxmox.com> References: <20251111140005.41510-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762869588953 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox_login_manager v2 3/4] fix: ui: remove app bar and stack the close button on body X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In landscape and portrait mode when adding a remote once the "Origin" field is selected, the top bar becomes a slightly different shade of blue. This occurs after the keyboard appears and the entire body begins to scroll. To fix this, the app bar was removed and the close button was stacked within the body. The height was also constrained to avoid system intrusion areas otherwise, the Continue button would not be visible. Additionally, in landscape mode, the logo caused render flex issues because the `Image`` widget was placed inside a `Column` and the logo was trying to take more height than the available height. This was fixed by removing the column and used `Align` widget to center the logo. Signed-off-by: Shan Shaji --- changes since v1: - Remove the SafeArea wrapping the stack. - Wrap the login body and Close button with SafeArea. - Stack the close button on top of loading overlay or else it would be impossible to press the close button. lib/proxmox_login_form.dart | 47 +++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index 8f290b4..80dc4a2 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -308,24 +308,17 @@ class _ProxmoxLoginPageState extends State { ), child: Scaffold( backgroundColor: ProxmoxColors.supportBlue, - extendBodyBehindAppBar: true, - appBar: AppBar( - elevation: 0.0, - backgroundColor: Colors.transparent, - leading: IconButton( - icon: const Icon(Icons.close), - tooltip: "Close", - onPressed: () => Navigator.of(context).pop(), - ), - ), body: Stack( children: [ - SingleChildScrollView( + SafeArea( + child: SingleChildScrollView( child: ConstrainedBox( constraints: BoxConstraints.tightFor( - height: MediaQuery.of(context).size.height), - child: SafeArea( - child: Padding( + height: MediaQuery.sizeOf(context).height - + MediaQuery.viewPaddingOf(context).bottom - + MediaQuery.viewPaddingOf(context).top, + ), + child: Padding( padding: EdgeInsets.symmetric( horizontal: MediaQuery.maybeOrientationOf(context) == Orientation.portrait @@ -347,15 +340,13 @@ class _ProxmoxLoginPageState extends State { mainAxisAlignment: MainAxisAlignment.center, children: [ Expanded( - child: Column( - mainAxisAlignment: MainAxisAlignment.center, - children: [ - Image.asset( - 'assets/images/proxmox_logo_symbol_wordmark.png', - package: 'proxmox_login_manager', - ), - ], - ), + child: Align( + alignment: Alignment.center, + child: Image.asset( + 'assets/images/proxmox_logo_symbol_wordmark.png', + package: 'proxmox_login_manager', + ), + ) ), ProxmoxLoginForm( originController: _originController, @@ -449,10 +440,16 @@ class _ProxmoxLoginPageState extends State { }), ), ), - ), - ), + )), if (_progressModel.inProgress > 0) ProxmoxProgressOverlay(message: _progressModel.message), + SafeArea( + child: IconButton( + icon: const Icon(Icons.close), + tooltip: "Close", + onPressed: () => Navigator.of(context).pop(), + ), + ), ], ), ), -- 2.50.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel