From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5CD3E1FF17A for ; Tue, 11 Nov 2025 14:59:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 645F1B835; Tue, 11 Nov 2025 15:00:19 +0100 (CET) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Tue, 11 Nov 2025 15:00:03 +0100 Message-ID: <20251111140005.41510-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251111140005.41510-1-s.shaji@proxmox.com> References: <20251111140005.41510-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762869588282 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox_login_manager v2 2/4] fix: ui: add more padding around the form in portrait mode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" portrait mode the margins around the "Origin" field are bit tight. To fix it, if the orientation is portrait set the horizontal padding to `12` and in landscape it will be `8`. The helper text was getting truncated after adding the padding. Inorder to fix that used `Text` widget. Signed-off-by: Shan Shaji --- lib/proxmox_login_form.dart | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index e193c57..8f290b4 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -72,11 +72,12 @@ class _ProxmoxLoginFormState extends State { if (widget.accessDomains == null) { return TextFormField( decoration: const InputDecoration( - icon: Icon(Icons.vpn_lock), - labelText: 'Origin', - hintText: 'e.g. 192.168.1.2', - helperText: - 'Protocol (https) and default port (8006 or 443) implied'), + icon: Icon(Icons.vpn_lock), + labelText: 'Origin', + hintText: 'e.g. 192.168.1.2', + helper: + Text('Protocol (https) and default port (8006 or 443) implied'), + ), textInputAction: TextInputAction.next, controller: widget.originController, validator: widget.originValidator, @@ -325,7 +326,12 @@ class _ProxmoxLoginPageState extends State { height: MediaQuery.of(context).size.height), child: SafeArea( child: Padding( - padding: const EdgeInsets.all(8.0), + padding: EdgeInsets.symmetric( + horizontal: MediaQuery.maybeOrientationOf(context) == + Orientation.portrait + ? 12 + : 8, + ), child: FutureBuilder?>( future: _accessDomains, builder: (context, snapshot) { -- 2.50.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel