From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E77FB1FF17A for ; Tue, 11 Nov 2025 15:01:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B58AABEE3; Tue, 11 Nov 2025 15:00:46 +0100 (CET) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Tue, 11 Nov 2025 15:00:01 +0100 Message-ID: <20251111140005.41510-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762869586260 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox_login_manager v2 0/4] fix #6983: ui: make cosmetic changes inside the login screen X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch series fixes the issues recieved as feedback after testing the IOS Test Flight build. - when adding a remote the continue button is initially submit-able, even though the "Origin" field is empty. taping continue will shop an error message and gray out the button. Fixed the issue by disabling the button by default. - In portrait mode the margins around the "Origin" field are bit tight. Fixed the issue by adding more padding around the form. - In landscape mode when adding a remote once the "Origin" field is selected, the top bar becomes a slightly different shade of blue. Fixed the issue by removing the app bar and stacked the close button. History ======= changes since v1: - The Continue button was disabled even though the Origin field had a value. In v1, I disabled the button by default so that it would only be enabled after successful form validation. However, when saved credentials already exist and tried to log in with those credentials (with the SSL toggle not disabled), the Origin field UI is displayed on the login screen. Since the button was disabled by default even though the Origin field contained value, i had to edit the field to enable the button again. To fix this, the button will be enabled if the origin value is not empty. - In v1, the overlay loading indicator was hiding the Close button, making it impossible to close the loading animation. To fix this, the Close button is now stacked above the overlay loading indicator. Shan Shaji (4): fix: ui: disable continue button by default in login form fix: ui: add more padding around the form in portrait mode fix: ui: remove app bar and stack the close button on body cleanup: run dart format command to fix formatting lib/proxmox_login_form.dart | 80 ++++++++++++++++++++----------------- 1 file changed, 43 insertions(+), 37 deletions(-) -- 2.50.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel