From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 475DA1FF17A for ; Tue, 11 Nov 2025 11:50:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95A4D636D; Tue, 11 Nov 2025 11:51:13 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Tue, 11 Nov 2025 11:50:57 +0100 Message-ID: <20251111105059.148997-7-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251111105059.148997-1-l.wagner@proxmox.com> References: <20251111105059.148997-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762858243832 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [RFC datacenter-manager 6/8] pdm-api-types: remote upid: allow to get native UPID type X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" In some places where RemoteUpids are handled, the native UPID type needs to be accessed, e.g. to access some of its fields. This commit adds the `native_upid` function, which will parse the raw UPID based on the type and return the native, product-specific UPID type. Signed-off-by: Lukas Wagner --- lib/pdm-api-types/src/remote_upid.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/pdm-api-types/src/remote_upid.rs b/lib/pdm-api-types/src/remote_upid.rs index 32106e42..10d3c1dc 100644 --- a/lib/pdm-api-types/src/remote_upid.rs +++ b/lib/pdm-api-types/src/remote_upid.rs @@ -20,6 +20,12 @@ pub struct RemoteUpid { upid: String, } +/// Type containing the parsed, native UPID for each type of remote. +pub enum NativeUpid { + PveUpid(pve_api_types::PveUpid), + PbsUpid(pbs_api_types::UPID), +} + impl RemoteUpid { /// Create a new remote UPID. pub fn new(remote: String, remote_type: RemoteType, upid: String) -> Self { @@ -54,6 +60,16 @@ impl RemoteUpid { self.remote_type } + /// Get the parsed, native UPID type. + /// + /// This function will return an error if the UPID could not be parsed. + pub fn native_upid(&self) -> Result { + Ok(match self.remote_type() { + RemoteType::Pve => NativeUpid::PveUpid(self.upid.parse()?), + RemoteType::Pbs => NativeUpid::PbsUpid(self.upid.parse()?), + }) + } + fn deduce_type(raw_upid: &str) -> Result { if raw_upid.parse::().is_ok() { Ok(RemoteType::Pve) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel