From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EF91C1FF15E for ; Mon, 10 Nov 2025 13:52:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D11915636; Mon, 10 Nov 2025 13:53:15 +0100 (CET) From: Shannon Sterz To: pve-devel@lists.proxmox.com Date: Mon, 10 Nov 2025 13:52:36 +0100 Message-ID: <20251110125236.247271-4-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251110125236.247271-1-s.sterz@proxmox.com> References: <20251110125236.247271-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762779138873 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH yew-mobile-gui 3/3] page login: skip consent banner when openid authorization is present X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" improves ux so users don't have to agree to the consent banner twice. Signed-off-by: Shannon Sterz --- src/pages/page_login.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/pages/page_login.rs b/src/pages/page_login.rs index 7875af3..63fad30 100644 --- a/src/pages/page_login.rs +++ b/src/pages/page_login.rs @@ -10,6 +10,7 @@ use pwt::widget::{Button, Column, Row}; use crate::widgets::TopNavBar; use proxmox_yew_comp::layout::card::standard_card; +use proxmox_yew_comp::utils::openid_redirection_authorization; use proxmox_yew_comp::{LoginPanel, Markdown}; use proxmox_login::Authentication; @@ -68,7 +69,9 @@ impl Component for PvePageLogin { props.consent_text.as_ref().filter(|t| !t.is_empty()) }; - let content: Html = if let Some(consent_text) = consent_text { + let content: Html = if let Some(consent_text) = consent_text + && openid_redirection_authorization().is_none() + { let card = standard_card(tr!("Consent"), (), ()) .class("pwt-scheme-neutral") .with_child( -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel