From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 82F811FF16B for ; Fri, 7 Nov 2025 15:44:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2501F15711; Fri, 7 Nov 2025 15:45:10 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 7 Nov 2025 15:43:45 +0100 Message-ID: <20251107144429.126790-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251107144429.126790-1-f.ebner@proxmox.com> References: <20251107144429.126790-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762526653057 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 7/8] ui: cpu flag selector: use simpler method to get all records of the store X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The Ext.data.Store class has a getData() method for getting all records, which is simpler than doing queryBy(Ext.returnTrue). Suggested-by: Daniel Kral Signed-off-by: Fiona Ebner --- New in v2. www/manager6/form/VMCPUFlagSelector.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index 2dbc21dc..630f79f5 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -70,8 +70,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { let store = me.getStore(); let flags = ''; - // ExtJS does not has a nice getAllRecords interface for stores :/ - store.queryBy(Ext.returnTrue).each(function (rec) { + store.getData().each(function (rec) { let s = rec.get('state'); if (s && s !== '=') { let f = rec.get('flag'); @@ -96,11 +95,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { me.unkownFlags = []; - me.getStore() - .queryBy(Ext.returnTrue) - .each(function (rec) { - rec.set('state', '='); - }); + me.getStore().getData().each((rec) => rec.set('state', '=')); let flags = value ? value.split(';') : []; flags.forEach(function (flag) { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel