From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B2D731FF183 for ; Wed, 5 Nov 2025 09:13:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E9361D68B; Wed, 5 Nov 2025 09:14:17 +0100 (CET) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Wed, 5 Nov 2025 09:12:55 +0100 Message-ID: <20251105081254.40625-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762330404651 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, qemu.rs, proxmox.com, lxc.rs, resources.rs] Subject: [pdm-devel] [PATCH datacenter-manager] api: fail with HTTP 403 Forbidden if user does have access to resource X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" As discussed in another patch series [1], if a user does not have enough permissions to see a resource, we should fail with 403 Forbidden instead of 401 Unauthorized. The UI relies on returning the correct error codes, since a 401 will redirect the user to the login mask. [1] https://lore.proxmox.com/pdm-devel/DDJLG0Y8J5CP.1NMNIMD5ZEYZE@proxmox.com/ Signed-off-by: Lukas Wagner --- Notes: There are a few instances where we return 401 in auth/tfa related code which I didn't touch - not sure if any of these should also be replaced. server/src/api/pve/lxc.rs | 2 +- server/src/api/pve/mod.rs | 4 ++-- server/src/api/pve/qemu.rs | 2 +- server/src/api/resources.rs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/api/pve/lxc.rs b/server/src/api/pve/lxc.rs index 61db8ff2..1b05a302 100644 --- a/server/src/api/pve/lxc.rs +++ b/server/src/api/pve/lxc.rs @@ -379,7 +379,7 @@ pub async fn lxc_remote_migrate( ); if target_privs & PRIV_RESOURCE_MIGRATE == 0 { http_bail!( - UNAUTHORIZED, + FORBIDDEN, "missing PRIV_RESOURCE_MIGRATE on target remote+vmid" ); } diff --git a/server/src/api/pve/mod.rs b/server/src/api/pve/mod.rs index fd4ea542..2b50afb8 100644 --- a/server/src/api/pve/mod.rs +++ b/server/src/api/pve/mod.rs @@ -197,7 +197,7 @@ pub async fn cluster_resources( .ok_or_else(|| format_err!("no authid available"))? .parse()?; if !user_info.any_privs_below(&auth_id, &["resource", &remote], PRIV_RESOURCE_AUDIT)? { - http_bail!(UNAUTHORIZED, "user has no access to resource list"); + http_bail!(FORBIDDEN, "user has no access to resource list"); } let cluster_resources = connect_to_remote(&remotes, &remote)? @@ -268,7 +268,7 @@ fn check_guest_list_permissions( let user_info = CachedUserInfo::new()?; if !user_info.any_privs_below(&auth_id, &["resource", remote], PRIV_RESOURCE_AUDIT)? { - http_bail!(UNAUTHORIZED, "user has no access to resource list"); + http_bail!(FORBIDDEN, "user has no access to resource list"); } let top_level_allowed = diff --git a/server/src/api/pve/qemu.rs b/server/src/api/pve/qemu.rs index 6158bef2..05fa92c1 100644 --- a/server/src/api/pve/qemu.rs +++ b/server/src/api/pve/qemu.rs @@ -427,7 +427,7 @@ pub async fn qemu_remote_migrate( ); if target_privs & PRIV_RESOURCE_MIGRATE == 0 { http_bail!( - UNAUTHORIZED, + FORBIDDEN, "missing PRIV_RESOURCE_MIGRATE on target remote+vmid" ); } diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs index e7d43987..dad3e6b6 100644 --- a/server/src/api/resources.rs +++ b/server/src/api/resources.rs @@ -286,7 +286,7 @@ pub(crate) async fn get_resources_impl( .ok_or_else(|| format_err!("no authid available"))? .parse()?; if !user_info.any_privs_below(&auth_id, &["resource"], PRIV_RESOURCE_AUDIT)? { - http_bail!(UNAUTHORIZED, "user has no access to resources"); + http_bail!(FORBIDDEN, "user has no access to resources"); } opt_auth_id = Some(auth_id); } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel