all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_login_manager 0/4] fix #6983: ui: make cosmetic changes inside the login screen
Date: Tue,  4 Nov 2025 18:38:05 +0100	[thread overview]
Message-ID: <20251104173809.90052-1-s.shaji@proxmox.com> (raw)

This patch series fixes the issues recieved as feedback after testing
the IOS Test Flight build.

- when adding a remote the continue button is initially submit-able, even though the
  "Origin" field is empty. taping continue will shop an error message and
  gray out the button. Fixed the issue by disabling the button by default.
- In portrait mode the margins around the "Origin" field are bit tight.
  Fixed the issue by adding more padding around the form.
- In landscape mode when adding a remote once the "Origin" field is
  selected, the top bar becomes a slightly different shade of blue. Fixed
  the issue by removing the app bar and stacked the close button.

Shan Shaji (4):
  fix: ui: disable continue button by default in login form
  fix: ui: add more padding around the form in portrait mode
  fix: ui: remove app bar and stack the close button on body
  cleanup: run dart format command to fix formatting

 lib/proxmox_login_form.dart | 280 ++++++++++++++++++------------------
 1 file changed, 141 insertions(+), 139 deletions(-)

-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-11-04 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 17:38 Shan Shaji [this message]
2025-11-04 17:38 ` [pve-devel] [PATCH proxmox_login_manager 1/4] fix: ui: disable continue button by default in login form Shan Shaji
2025-11-04 17:38 ` [pve-devel] [PATCH proxmox_login_manager 2/4] fix: ui: add more padding around the form in portrait mode Shan Shaji
2025-11-04 17:38 ` [pve-devel] [PATCH proxmox_login_manager 3/4] fix: ui: remove app bar and stack the close button on body Shan Shaji
2025-11-04 17:38 ` [pve-devel] [PATCH proxmox_login_manager 4/4] cleanup: run dart format command to fix formatting Shan Shaji
2025-11-11 14:05 ` [pve-devel] [PATCH proxmox_login_manager 0/4] fix #6983: ui: make cosmetic changes inside the login screen Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104173809.90052-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal