From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A608F1FF187 for ; Mon, 3 Nov 2025 12:31:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C05F1AB90; Mon, 3 Nov 2025 12:32:14 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 3 Nov 2025 12:31:08 +0100 Message-ID: <20251103113120.239455-6-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251103113120.239455-1-c.ebner@proxmox.com> References: <20251103113120.239455-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762169483561 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 05/17] api/datastore: add dedicated datastore helper to set snapshot notes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" In an effort to decouple the api from the datastore backend. Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 11 +++++++++++ src/api2/admin/datastore.rs | 7 +------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index cc1267d78..ae85be76d 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -2475,4 +2475,15 @@ impl DataStore { replace_file(&path, blob.raw_data(), CreateOptions::new(), false)?; Ok(()) } + + /// Set the notes for given snapshots. + pub fn set_notes(self: &Arc, notes: String, snapshot: BackupDir) -> Result<(), Error> { + let backend = self.backend().context("failed to get backend")?; + snapshot + .update_manifest(&backend, |manifest| { + manifest.unprotected["notes"] = notes.into(); + }) + .map_err(|err| format_err!("unable to update manifest blob - {err}"))?; + Ok(()) + } } diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index 6881b4093..000cf80c3 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -2090,12 +2090,7 @@ pub fn set_notes( )?; let backup_dir = datastore.backup_dir(ns, backup_dir)?; - - backup_dir - .update_manifest(&datastore.backend()?, |manifest| { - manifest.unprotected["notes"] = notes.into(); - }) - .map_err(|err| format_err!("unable to update manifest blob - {}", err))?; + datastore.set_notes(notes, backup_dir)?; Ok(()) } -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel