From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 86C4C1FF187 for ; Mon, 3 Nov 2025 12:31:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B5C61A99D; Mon, 3 Nov 2025 12:31:48 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 3 Nov 2025 12:31:17 +0100 Message-ID: <20251103113120.239455-15-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251103113120.239455-1-c.ebner@proxmox.com> References: <20251103113120.239455-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762169485735 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 14/17] datastore: add locking to protect against races on chunk insert for s3 X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Acquire the per-chunk file lock to get exclusive access to the chunk on insert and make it possible to guarantee that s3 backend operations and the local caches reflect the consistent state without other operations such as verify chunk renaming or garbage collection interfering. Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 1b3f3496c..b36424131 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -1867,6 +1867,7 @@ impl DataStore { digest: &[u8; 32], backend: &DatastoreBackend, ) -> Result<(bool, u64), Error> { + let _chunk_lock_guard = self.lock_chunk_for_backend(digest)?; match backend { DatastoreBackend::Filesystem => self.inner.chunk_store.insert_chunk(chunk, digest), DatastoreBackend::S3(s3_client) => self.insert_chunk_cached(chunk, digest, &s3_client), @@ -1888,6 +1889,7 @@ impl DataStore { digest: &[u8; 32], backend: &DatastoreBackend, ) -> Result<(bool, u64), Error> { + let _chunk_lock_guard = self.lock_chunk_for_backend(digest)?; match backend { DatastoreBackend::Filesystem => self.inner.chunk_store.insert_chunk(chunk, digest), DatastoreBackend::S3(s3_client) => { -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel