From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 272421FF15C for ; Fri, 31 Oct 2025 13:28:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7EF4109CF; Fri, 31 Oct 2025 13:28:44 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 31 Oct 2025 13:27:42 +0100 Message-ID: <20251031122834.62482-7-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251031122834.62482-1-f.ebner@proxmox.com> References: <20251031122834.62482-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761913704437 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 6/7] ui: cpu flag selector: code style: use 'let' for declarations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Fiona Ebner --- www/manager6/form/VMCPUFlagSelector.js | 28 +++++++++++++------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index 874068cf..2dbc21dc 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -66,13 +66,13 @@ Ext.define('PVE.form.VMCPUFlagSelector', { }, getValue: function () { - var me = this; - var store = me.getStore(); - var flags = ''; + let me = this; + let store = me.getStore(); + let flags = ''; // ExtJS does not has a nice getAllRecords interface for stores :/ store.queryBy(Ext.returnTrue).each(function (rec) { - var s = rec.get('state'); + let s = rec.get('state'); if (s && s !== '=') { let f = rec.get('flag'); if (flags === '') { @@ -89,8 +89,8 @@ Ext.define('PVE.form.VMCPUFlagSelector', { }, setValue: function (value) { - var me = this; - var store = me.getStore(); + let me = this; + let store = me.getStore(); me.value = value || ''; @@ -102,12 +102,12 @@ Ext.define('PVE.form.VMCPUFlagSelector', { rec.set('state', '='); }); - var flags = value ? value.split(';') : []; + let flags = value ? value.split(';') : []; flags.forEach(function (flag) { - var sign = flag.substr(0, 1); + let sign = flag.substr(0, 1); flag = flag.substr(1); - var rec = store.findRecord('flag', flag, 0, false, true, true); + let rec = store.findRecord('flag', flag, 0, false, true, true); if (rec !== null) { rec.set('state', sign); } else { @@ -116,7 +116,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { }); store.reload(); - var res = me.mixins.field.setValue.call(me, value); + let res = me.mixins.field.setValue.call(me, value); return res; }, @@ -142,7 +142,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { dataIndex: 'state', width: 95, onWidgetAttach: function (column, widget, record) { - var val = record.get('state') || '='; + let val = record.get('state') || '='; widget.down('[inputValue=' + val + ']').setValue(true); // TODO: disable if selected CPU model and flag are incompatible }, @@ -154,10 +154,10 @@ Ext.define('PVE.form.VMCPUFlagSelector', { value: '=', listeners: { change: function (f, value) { - var v = Object.values(value)[0]; + let v = Object.values(value)[0]; f.getWidgetRecord().set('state', v); - var view = this.up('grid'); + let view = this.up('grid'); view.dirty = view.getValue() !== view.originalValue; view.checkDirty(); //view.checkChange(); @@ -195,7 +195,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { ], initComponent: function () { - var me = this; + let me = this; // static class store, thus gets not recreated, so ensure defaults are set! me.getStore().data.forEach(function (v) { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel