From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E01AC1FF15C for ; Fri, 31 Oct 2025 11:36:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48601E960; Fri, 31 Oct 2025 11:37:22 +0100 (CET) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Fri, 31 Oct 2025 11:36:10 +0100 Message-ID: <20251031103709.60233-4-f.weber@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251031103709.60233-1-f.weber@proxmox.com> References: <20251031103709.60233-1-f.weber@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761907024426 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: [pve-devel] [PATCH storage 3/5] storage: activate/map volumes: verify and pass hints to plugin X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Plugin methods {activate,map}_volume accept an optional hints parameter. Make PVE::Storage::{activate,map}_volumes also accept hints, verify they are consistent with the schema, and pass them down to the plugin when activating the volumes. Signed-off-by: Friedrich Weber --- src/PVE/Storage.pm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index ca0bf0e..2371443 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -1122,7 +1122,9 @@ sub vdisk_create_base { } sub map_volume { - my ($cfg, $volid, $snapname) = @_; + my ($cfg, $volid, $snapname, $hints) = @_; + + PVE::Storage::Plugin::verify_hints($hints); my ($storeid, $volname) = parse_volume_id($volid); @@ -1130,7 +1132,7 @@ sub map_volume { my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); - return $plugin->map_volume($storeid, $scfg, $volname, $snapname); + return $plugin->map_volume($storeid, $scfg, $volname, $snapname, $hints); } sub unmap_volume { @@ -1386,10 +1388,12 @@ sub deactivate_storage { } sub activate_volumes { - my ($cfg, $vollist, $snapname) = @_; + my ($cfg, $vollist, $snapname, $hints) = @_; return if !($vollist && scalar(@$vollist)); + PVE::Storage::Plugin::verify_hints($hints); + my $storagehash = {}; foreach my $volid (@$vollist) { my ($storeid, undef) = parse_volume_id($volid); @@ -1404,7 +1408,7 @@ sub activate_volumes { my ($storeid, $volname) = parse_volume_id($volid); my $scfg = storage_config($cfg, $storeid); my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); - $plugin->activate_volume($storeid, $scfg, $volname, $snapname, $cache); + $plugin->activate_volume($storeid, $scfg, $volname, $snapname, $cache, $hints); } } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel