From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DD2B91FF165 for ; Thu, 23 Oct 2025 10:30:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D1373344A; Thu, 23 Oct 2025 10:30:58 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Thu, 23 Oct 2025 10:30:53 +0200 Message-ID: <20251023083054.116763-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251023083054.116763-1-m.sandoval@proxmox.com> References: <20251023083054.116763-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761208246913 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/2] improve some translatable strings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Regarding the change in Restore.js: In certain languages (e.g. Spanish) CT and VM would have different genders, hence it is not possible to use the same string without having at least one wrong translation. Regarding the batch size label, the `b` in batch size is not very obvious in meaning from a i18n perspective. Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/MetricServerView.js | 2 +- www/manager6/window/Restore.js | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager6/dc/MetricServerView.js b/www/manager6/dc/MetricServerView.js index 1cb9d516..ebfdf2e4 100644 --- a/www/manager6/dc/MetricServerView.js +++ b/www/manager6/dc/MetricServerView.js @@ -369,7 +369,7 @@ Ext.define('PVE.dc.InfluxDBEdit', { { xtype: 'proxmoxintegerfield', name: 'max-body-size', - fieldLabel: gettext('Batch Size (b)'), + fieldLabel: gettext('Batch Size (bits)'), minValue: 1, emptyText: '25000000', submitEmpty: false, diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 690116df..f376da9a 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window/Restore.js @@ -93,12 +93,11 @@ Ext.define('PVE.window.Restore', { }; if (view.vmid) { - confirmMsg += `. ${Ext.String.format( - gettext('This will permanently erase current {0} data.'), - view.vmtype === 'lxc' ? 'CT' : 'VM', - )}`; if (view.vmtype === 'lxc') { + confirmMsg += `. ${gettext('This will permanently erase current CT data.')}`; confirmMsg += `
${gettext('Mount point volumes are also erased.')}`; + } else { + confirmMsg += `. ${gettext('This will permanently erase current VM data.')}`; } Ext.Msg.confirm(gettext('Confirm'), confirmMsg, function (btn) { if (btn === 'yes') { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel