From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DDCB41FF191 for ; Tue, 21 Oct 2025 13:11:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 266311B8D6; Tue, 21 Oct 2025 13:11:46 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Tue, 21 Oct 2025 13:11:12 +0200 Message-ID: <20251021111129.294349-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251021111129.294349-1-c.ebner@proxmox.com> References: <20251021111129.294349-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761045095987 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [resources.rs] Subject: [pdm-devel] [PATCH datacenter-manager v3 02/19] server: api: pass remote as reference to fetching helpers X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" None of the helpers requires ownership of the remote, therefore pass it as shared reference. This is in preparation for passing the remote also to the search term filtering to allow matching the remote type. Signed-off-by: Christian Ebner --- Changes since version 2: - no changes server/src/api/resources.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs index d629c65..21143a8 100644 --- a/server/src/api/resources.rs +++ b/server/src/api/resources.rs @@ -255,7 +255,7 @@ pub(crate) async fn get_resources_impl( } let filter = filters.clone(); let handle = tokio::spawn(async move { - let (mut resources, error) = match get_resources_for_remote(remote, max_age).await { + let (mut resources, error) = match get_resources_for_remote(&remote, max_age).await { Ok(resources) => (resources, None), Err(error) => { tracing::debug!("failed to get resources from remote - {error:?}"); @@ -700,7 +700,7 @@ static CACHE: LazyLock>> = /// /// If recent enough cached data is available, it is returned /// instead of calling out to the remote. -async fn get_resources_for_remote(remote: Remote, max_age: u64) -> Result, Error> { +async fn get_resources_for_remote(remote: &Remote, max_age: u64) -> Result, Error> { let remote_name = remote.id.to_owned(); if let Some(cached_resource) = get_cached_resources(&remote_name, max_age) { Ok(cached_resource.resources) @@ -756,7 +756,7 @@ fn update_cached_resources(remote: &str, resources: &[Resource], now: i64) { } /// Fetch remote resources and map to pdm-native data types. -async fn fetch_remote_resource(remote: Remote) -> Result, Error> { +async fn fetch_remote_resource(remote: &Remote) -> Result, Error> { let mut resources = Vec::new(); let remote_name = remote.id.to_owned(); -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel