From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6A6951FF191 for ; Tue, 21 Oct 2025 08:38:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5BC41167FC; Tue, 21 Oct 2025 08:38:40 +0200 (CEST) From: Dietmar Maurer To: pdm-devel@lists.proxmox.com Date: Tue, 21 Oct 2025 08:38:03 +0200 Message-ID: <20251021063803.2046329-3-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251021063803.2046329-1-dietmar@proxmox.com> References: <20251021063803.2046329-1-dietmar@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.585 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [info.name, info.id, overview.rs] Subject: [pdm-devel] [PATCH datacenter-manager 3/3] ui: lxc: remove wrong PartialEq implementation X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" i.e. we want to update the view on cpu property changes. Signed-off-by: Dietmar Maurer --- ui/src/pve/lxc/overview.rs | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/ui/src/pve/lxc/overview.rs b/ui/src/pve/lxc/overview.rs index 3c5ead4..4164727 100644 --- a/ui/src/pve/lxc/overview.rs +++ b/ui/src/pve/lxc/overview.rs @@ -20,7 +20,7 @@ use pdm_client::types::{IsRunning, LxcStatus}; use crate::renderer::{separator, status_row}; -#[derive(Clone, Debug, Properties)] +#[derive(Clone, Debug, Properties, PartialEq)] pub struct LxcOverviewPanel { remote: String, node: String, @@ -35,20 +35,6 @@ pub struct LxcOverviewPanel { pub status_interval: u32, } -impl PartialEq for LxcOverviewPanel { - fn eq(&self, other: &Self) -> bool { - if self.remote == other.remote && self.node == other.node { - // only check some fields, so we don't update when e.g. only the cpu changes - self.info.name == other.info.name - && self.info.id == other.info.id - && self.info.node == other.node - } else { - false - } - } -} -impl Eq for LxcOverviewPanel {} - impl LxcOverviewPanel { pub fn new(remote: String, node: String, info: PveLxcResource) -> Self { yew::props!(Self { remote, node, info }) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel