From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E1B11FF15C for ; Fri, 17 Oct 2025 14:10:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 408161975; Fri, 17 Oct 2025 14:11:00 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Date: Fri, 17 Oct 2025 14:10:09 +0200 Message-ID: <20251017121009.212499-14-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251017121009.212499-1-l.wagner@proxmox.com> References: <20251017121009.212499-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760703020811 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager v2 13/13] remote updates: avoid unnecessary clone X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Signed-off-by: Lukas Wagner --- Notes: New in v2 server/src/api/remote_updates.rs | 2 +- server/src/remote_updates.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/api/remote_updates.rs b/server/src/api/remote_updates.rs index c1309432..bea2d864 100644 --- a/server/src/api/remote_updates.rs +++ b/server/src/api/remote_updates.rs @@ -201,7 +201,7 @@ async fn apt_get_changelog( let (config, _digest) = pdm_config::remotes::config()?; let remote = get_remote(&config, &remote)?; - remote_updates::get_changelog(remote.clone(), &node, options.name).await + remote_updates::get_changelog(remote, &node, options.name).await } const APT_SUBDIRS: SubdirMap = &[ diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs index 4c70495b..87c6afd9 100644 --- a/server/src/remote_updates.rs +++ b/server/src/remote_updates.rs @@ -83,10 +83,10 @@ pub async fn update_apt_database(remote: &Remote, node: &str) -> Result Result { +pub async fn get_changelog(remote: &Remote, node: &str, package: String) -> Result { match remote.ty { RemoteType::Pve => { - let client = connection::make_pve_client(&remote)?; + let client = connection::make_pve_client(remote)?; client .get_package_changelog(node, package, None) @@ -94,7 +94,7 @@ pub async fn get_changelog(remote: Remote, node: &str, package: String) -> Resul .map_err(Into::into) } RemoteType::Pbs => { - let client = connection::make_pbs_client(&remote)?; + let client = connection::make_pbs_client(remote)?; client .get_package_changelog(package, None) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel