From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D6F021FF15E for ; Mon, 13 Oct 2025 10:56:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A588BEF83; Mon, 13 Oct 2025 10:56:45 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Mon, 13 Oct 2025 10:56:20 +0200 Message-ID: <20251013085623.211136-5-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251013085623.211136-1-c.ebner@proxmox.com> References: <20251013085623.211136-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760345766209 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: [pdm-devel] [PATCH datacenter-manager 4/7] ui: dashboard: extend node panel creation by remote type X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Make the node panel instantiation logic reusable for the PBS remotes by passing the remote type as additional parameter, switching the rendered node status information based on that. Signed-off-by: Christian Ebner --- ui/src/dashboard/mod.rs | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/ui/src/dashboard/mod.rs b/ui/src/dashboard/mod.rs index f54c509..ff63f6a 100644 --- a/ui/src/dashboard/mod.rs +++ b/ui/src/dashboard/mod.rs @@ -158,16 +158,26 @@ impl PdmDashboard { .into() } - fn create_node_panel(&self, ctx: &yew::Context, icon: &str, title: String) -> Panel { + fn create_node_panel( + &self, + ctx: &yew::Context, + icon: &str, + title: String, + remote_type: RemoteType, + ) -> Panel { let mut search_terms = vec![SearchTerm::new("node").category(Some("type"))]; let (status_icon, text): (Fa, String) = match &self.status { Some(status) => { - match status.pve_nodes { + let node_status = match remote_type { + RemoteType::Pve => &status.pve_nodes, + RemoteType::Pbs => &status.pbs_nodes, + }; + match node_status { NodeStatusCount { online, offline, unknown, - } if offline > 0 => { + } if *offline > 0 => { search_terms.push(SearchTerm::new("offline").category(Some("status"))); ( Status::Error.into(), @@ -178,7 +188,7 @@ impl PdmDashboard { ), ) } - NodeStatusCount { unknown, .. } if unknown > 0 => { + NodeStatusCount { unknown, .. } if *unknown > 0 => { search_terms.push(SearchTerm::new("unknown").category(Some("status"))); ( Status::Warning.into(), @@ -567,6 +577,7 @@ impl Component for PdmDashboard { ctx, "building", tr!("Virtual Environment Nodes"), + RemoteType::Pve, )) .with_child(self.create_guest_panel(GuestType::Qemu)) .with_child(self.create_guest_panel(GuestType::Lxc)) -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel