From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CC1D61FF183 for ; Wed, 8 Oct 2025 17:22:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F20AFC48B; Wed, 8 Oct 2025 17:22:12 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 8 Oct 2025 17:21:18 +0200 Message-ID: <20251008152125.849216-6-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251008152125.849216-1-c.ebner@proxmox.com> References: <20251008152125.849216-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759936867482 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 05/12] local store cache: serve response fetched from s3 backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" If the chunk file was not found in the local datastore cache or the chunk file was the zero marker, it is fetched from the s3 backend and re-inserted. Currently, the chunk is then re-read from the file, but that is not required. Serve the still in-memory chunk data as result of the cacher access call. Signed-off-by: Christian Ebner --- pbs-datastore/src/local_datastore_lru_cache.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pbs-datastore/src/local_datastore_lru_cache.rs b/pbs-datastore/src/local_datastore_lru_cache.rs index fe0b336ff..7d0b3e114 100644 --- a/pbs-datastore/src/local_datastore_lru_cache.rs +++ b/pbs-datastore/src/local_datastore_lru_cache.rs @@ -124,7 +124,7 @@ impl LocalDatastoreLruCache { let bytes = response.content.collect().await?.to_bytes(); let chunk = DataBlob::from_raw(bytes.to_vec())?; self.store.insert_chunk(&chunk, digest)?; - std::fs::File::open(&path)? + return Ok(Some(chunk)); } } } else { @@ -147,8 +147,7 @@ impl LocalDatastoreLruCache { let bytes = response.content.collect().await?.to_bytes(); let chunk = DataBlob::from_raw(bytes.to_vec())?; self.store.insert_chunk(&chunk, digest)?; - let mut file = std::fs::File::open(&path)?; - DataBlob::load_from_reader(&mut file)? + return Ok(Some(chunk)); } } } else { -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel