From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4A62E1FF183 for ; Wed, 8 Oct 2025 16:10:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 70704A5FD; Wed, 8 Oct 2025 16:10:25 +0200 (CEST) From: Shan Shaji To: pdm-devel@lists.proxmox.com Date: Wed, 8 Oct 2025 16:09:43 +0200 Message-ID: <20251008140943.300897-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759932561544 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [termproxy.rs] Subject: [pdm-devel] [PATCH datacenter-manager] fix: api: allow non-pam users to access shell X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Remove the explicit restriction that only pam users can access the shell. This is safe to do, as all users that are not root@pam will be shown with a login shell. So they need to have some (PAM) login credentials available. This changes is useful for setups where a host integrates with central authentication systems (e.g. LDAP or Active Directory) either as a PDM realm or as a PAM plugin. It also allows environments that favor non-pam users for PDM by default, but still want to keep PAM accounts available for admnistrators. Reference: pve-manager commit (7914f5e7b) and proxmox-backup commit (c77dfaf31), these commits are already applied for PVE and PBS. Signed-off-by: Shan Shaji --- server/src/api/nodes/termproxy.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/src/api/nodes/termproxy.rs b/server/src/api/nodes/termproxy.rs index 8d7c1ff..3f689ef 100644 --- a/server/src/api/nodes/termproxy.rs +++ b/server/src/api/nodes/termproxy.rs @@ -63,7 +63,7 @@ pub const SHELL_CMD_SCHEMA: Schema = StringSchema::new("The command to run.") } }, access: { - description: "Restricted to users on realm 'pam'", + description: "The user needs `Sys.Console` privilege on `/system`", permission: &Permission::Privilege(&["system"], PRIV_SYS_CONSOLE, false), } )] @@ -81,10 +81,6 @@ async fn termproxy(cmd: Option, rpcenv: &mut dyn RpcEnvironment) -> Resu let userid = auth_id.user(); - if userid.realm() != "pam" { - bail!("only pam users can use the console"); - } - let path = "/system"; // use port 0 and let the kernel decide which port is free -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel