From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2F03F1FF183 for ; Wed, 8 Oct 2025 12:47:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEFD250BA; Wed, 8 Oct 2025 12:47:58 +0200 (CEST) From: Shan Shaji To: pbs-devel@lists.proxmox.com Date: Wed, 8 Oct 2025 12:47:11 +0200 Message-ID: <20251008104711.114109-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759920415306 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2] fix #6398: api: allow non-pam users to access shell X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Shan Shaji Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Remove the explicit restriction that only pam users can access the shell. This is safe to do, as all users that are not root@pam will be shown with a login shell. So they need to have some (PAM) login credentials available. This change is useful for setups where a host integrates with central authentication systems (e.g. LDAP, Active Directory, or OIDC), either as a PBS realm or as a PAM plugin. It also allows environments that favor non-pam users for PBS by default, but still want to keep PAM accounts available for admnistrators. Reference: pve-manager commit 7914f5e7b ("node console: allow usage for non-pam realms), which already applied the same change for PVE. Signed-off-by: Shan Shaji --- changes since v1: Thanks @Thomas - Updated commit message with more details. src/api2/node/mod.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/api2/node/mod.rs b/src/api2/node/mod.rs index e7c6213c..34d4fb77 100644 --- a/src/api2/node/mod.rs +++ b/src/api2/node/mod.rs @@ -92,7 +92,7 @@ pub const SHELL_CMD_SCHEMA: Schema = StringSchema::new("The command to run.") } }, access: { - description: "Restricted to users on realm 'pam'", + description: "The user needs Sys.Console on /system.", permission: &Permission::Privilege(&["system"], PRIV_SYS_CONSOLE, false), } )] @@ -110,10 +110,6 @@ async fn termproxy(cmd: Option, rpcenv: &mut dyn RpcEnvironment) -> Resu let userid = auth_id.user(); - if userid.realm() != "pam" { - bail!("only pam users can use the console"); - } - let path = "/system"; // use port 0 and let the kernel decide which port is free -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel