From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 83FCB1FF191 for ; Tue, 7 Oct 2025 14:25:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95C5817D5D; Tue, 7 Oct 2025 14:25:16 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 7 Oct 2025 14:25:00 +0200 Message-ID: <20251007122509.66194-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251007122509.66194-1-f.ebner@proxmox.com> References: <20251007122509.66194-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759839883561 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v3 1/2] systemd: add sd_notify() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Implement a pure Perl reimplementation of systemd's sd_notify() as defined in systemd/sd-daemon.h, see also 'man 3 sd_notify'. The initial user of this helper is intended to be the pve-dbus-vmstate service, so it can notify startup completion only once the dbus-vmstate QEMU object is ready to be used. EAGAIN is not checked for, because it does not occur for blocking Unix domain sockets, see 'man 2 send'. Co-developed-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- Changes in v3: * Expand commit message. * Use $socket->{send,shutdown) methods. * Print $IO::Socket::errstr in case of error. * Unset NOTIFY_SOCKET environment variable only after sending the message. src/PVE/Systemd.pm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/src/PVE/Systemd.pm b/src/PVE/Systemd.pm index e6d6f88..d0a291d 100644 --- a/src/PVE/Systemd.pm +++ b/src/PVE/Systemd.pm @@ -3,9 +3,12 @@ package PVE::Systemd; use strict; use warnings; +use IO::Socket::UNIX; use Net::DBus qw(dbus_uint32 dbus_uint64 dbus_boolean); use Net::DBus::Callback; use Net::DBus::Reactor; +use POSIX qw(EINTR); +use Socket qw(SOCK_DGRAM); use PVE::Tools qw(file_set_contents file_get_contents trim); @@ -282,4 +285,32 @@ sub write_ini { file_set_contents($filename, $content); } +# This is a pure Perl reimplementation of systemd's sd_notify() as defined in systemd/sd-daemon.h +sub sd_notify { + my ($unset_environment, $state) = @_; + + my $socket_path = $ENV{NOTIFY_SOCKET}; + + my $socket = IO::Socket::UNIX->new( + Type => SOCK_DGRAM(), + Peer => $socket_path, + ) or die "unable to connect to socket $socket_path to notify systemd - $IO::Socket::errstr\n"; + + # we won't be reading from the socket + $socket->shutdown(SHUT_RD); + + my $sent = 0; + my $total = length($state); + while ($sent < $total) { + my $res = $socket->send($state); + die "sending to $socket_path failed - $!" if !$res && $! != EINTR; + $sent += $res if $res; + } + $socket->flush(); + + close($socket); + + delete($ENV{NOTIFY_SOCKET}) if $unset_environment; +} + 1; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel