From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B3CDF1FF163 for ; Mon, 6 Oct 2025 13:57:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F373A2B8D; Mon, 6 Oct 2025 13:57:25 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 6 Oct 2025 13:55:53 +0200 Message-ID: <20251006115648.804286-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251006115648.804286-1-f.ebner@proxmox.com> References: <20251006115648.804286-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759751783608 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 2/2] migration: conntrack: avoid crash when dbus-vmstate object cannot be added (quickly enough) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the community forum [0], it might happen that the dbus-vmstate object is not added (quickly enough) to the target QEMU instance, before the migration state is loaded. This would result in a crash of the target instance: > kvm: Unknown savevm section or instance 'dbus-vmstate/dbus-vmstate' > 0. Make sure that your current VM setup matches your saved VM setup, > including any hotplugged devices > kvm: load of migration failed: Invalid argument This is after the configuration is already moved and thus there also is no source instance running anymore. Change the type of the 'pve-dbus-vmstate@' service to 'notify', so that starting the service returns success only after the 'dbus-vmstate' object has been added to the QEMU instance. [0]: https://forum.proxmox.com/threads/172588/ Signed-off-by: Fiona Ebner --- Dependency bump qemu-server -> pve-common needed! Changes in v2: * Different approach, make the service type=notify instead of waiting in a sleep+check-loop until the object shows up via QMP 'qom-list'. src/usr/dbus-vmstate | 3 +++ src/usr/pve-dbus-vmstate@.service | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/usr/dbus-vmstate b/src/usr/dbus-vmstate index ac6f8cfb..b2baa840 100755 --- a/src/usr/dbus-vmstate +++ b/src/usr/dbus-vmstate @@ -15,6 +15,7 @@ use Net::DBus::Reactor; use PVE::QemuServer::Helpers; use PVE::QemuServer::QMPHelpers qw(qemu_objectadd qemu_objectdel); use PVE::SafeSyslog; +use PVE::Systemd; use PVE::Tools; use base qw(Net::DBus::Object); @@ -165,4 +166,6 @@ qemu_objectadd($vmid, 'pve-vmstate', 'dbus-vmstate', 'id-list' => "pve-vmstate-$vmid", ); +PVE::Systemd::sd_notify(0, "READY=1\n"); + Net::DBus::Reactor->main()->run(); diff --git a/src/usr/pve-dbus-vmstate@.service b/src/usr/pve-dbus-vmstate@.service index 56b4e285..616f6979 100644 --- a/src/usr/pve-dbus-vmstate@.service +++ b/src/usr/pve-dbus-vmstate@.service @@ -6,5 +6,5 @@ PartOf=%i.scope [Service] Slice=qemu.slice -Type=simple +Type=notify ExecStart=/usr/libexec/qemu-server/dbus-vmstate %i -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel