From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 07F581FF187 for ; Mon, 6 Oct 2025 12:19:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84A2D27E8B; Mon, 6 Oct 2025 12:19:41 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Mon, 6 Oct 2025 12:19:28 +0200 Message-ID: <20251006101933.90655-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759745949580 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-firewall/ve-rs v2 0/3] Fix ICMP types in nftables X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Currently when setting ICMP types on the old firewall (iptables) then switching to the new one (nftables) a few types will fail because they have been renamed in nftables or do not exist in nftables. This affects both icmp and icmpv6 where we now map options that do not exist in nftables to their respective type/code combinations. This allows us to have exactly the same behavior in nftables as we have in iptables. Changelog: v1, thanks Stefan and Thomas: * no hard error when mapping not possible * map all the types by falling back to custom type/code * also map icmp types in addition to icmpv6 ve-rs: Gabriel Goller (1): fix: firewall: introduce iptables to nftables mapping for icmpv6-types Wolfgang Bumiller (1): fix: firewall: introduce iptables to nftables mapping for icmp-types proxmox-ve-config/src/firewall/cluster.rs | 9 +- proxmox-ve-config/src/firewall/types/rule.rs | 9 +- .../src/firewall/types/rule_match.rs | 139 +++++++++++++++--- 3 files changed, 129 insertions(+), 28 deletions(-) proxmox-firewall: Gabriel Goller (1): tests: add icmpv6 type mapping test proxmox-firewall/tests/input/host.fw | 1 + .../integration_tests__firewall.snap | 63 +++++++++++++++++++ 2 files changed, 64 insertions(+) Summary over all repositories: 5 files changed, 193 insertions(+), 28 deletions(-) -- Generated by git-murpp 0.8.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel