From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4BB241FF16F for ; Tue, 30 Sep 2025 10:02:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C2133CFE; Tue, 30 Sep 2025 10:02:22 +0200 (CEST) From: Christian Ebner To: pdm-devel@lists.proxmox.com Date: Tue, 30 Sep 2025 10:02:04 +0200 Message-ID: <20250930080207.111162-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250930080207.111162-1-c.ebner@proxmox.com> References: <20250930080207.111162-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759219318589 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox v2 3/3] proxmox-login: add compat mode to fallback to PBS3 ticket parsing X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" The ticket info field is present for Proxmox Backup Server version 3 login response data, the client however switches to http-only in this case. Allow to use the old authentication workflow instead by extending the compat mode by `Pbs3Ticket`, resulting in a full ticket instead of the http-only one. Signed-off-by: Christian Ebner --- changes since version 1: - fix check for CompatMode::Pbs3Ticket not being set proxmox-login/src/lib.rs | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/proxmox-login/src/lib.rs b/proxmox-login/src/lib.rs index e7b8e023..c919c6a0 100644 --- a/proxmox-login/src/lib.rs +++ b/proxmox-login/src/lib.rs @@ -58,6 +58,7 @@ pub enum CompatMode { #[default] Generic, PveTfa, + Pbs3Ticket, } fn normalize_url(mut api_url: String) -> String { @@ -216,15 +217,17 @@ impl Login { )); } - // `ticket_info` is set when the server sets the ticket via an HttpOnly cookie. this also - // means we do not have access to the cookie itself which happens for example in a browser. - // assume that the cookie is handled properly by the context (browser) and don't worry - // about handling it ourselves. - if let Some(ref ticket) = response.ticket_info { - let ticket = ticket.parse()?; - return Ok(TicketResult::HttpOnly( - self.authentication_for(ticket, response)?, - )); + if self.compat_mode != CompatMode::Pbs3Ticket { + // `ticket_info` is set when the server sets the ticket via an HttpOnly cookie. this also + // means we do not have access to the cookie itself which happens for example in a browser. + // assume that the cookie is handled properly by the context (browser) and don't worry + // about handling it ourselves. + if let Some(ref ticket) = response.ticket_info { + let ticket = ticket.parse()?; + return Ok(TicketResult::HttpOnly( + self.authentication_for(ticket, response)?, + )); + } } // old authentication flow where we needed to handle the ticket ourselves even in the -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel