From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9C2CD1FF1A6 for ; Mon, 29 Sep 2025 15:12:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D4C21283D; Mon, 29 Sep 2025 15:12:22 +0200 (CEST) From: Dominik Csapak To: yew-devel@lists.proxmox.com Date: Mon, 29 Sep 2025 15:12:11 +0200 Message-ID: <20250929131219.2932214-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250929131219.2932214-1-d.csapak@proxmox.com> References: <20250929131219.2932214-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [yew-devel] [PATCH yew-widget-toolkit 3/3] state: keyed slab tree: panic on inserting duplicate keys in debug mode X-BeenThere: yew-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Yew framework devel list at Proxmox List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Yew framework devel list at Proxmox Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: yew-devel-bounces@lists.proxmox.com Sender: "yew-devel" check on insert/append if the keys already exist, but only in debug mode to not unnecessarily slow down release builds. Signed-off-by: Dominik Csapak --- src/state/tree_store/keyed_slab_tree.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/state/tree_store/keyed_slab_tree.rs b/src/state/tree_store/keyed_slab_tree.rs index df163a2..c7044d1 100644 --- a/src/state/tree_store/keyed_slab_tree.rs +++ b/src/state/tree_store/keyed_slab_tree.rs @@ -449,6 +449,12 @@ impl KeyedSlabTree { .append_subtree_node(subtree, subtree_node, level, parent); let key_cache = self.calculate_cache(node_id); + #[cfg(debug_assertions)] + for key in key_cache.keys() { + if self.key_cache.contains_key(key) { + panic!("append_subtree_node: duplicate key {key:?}"); + } + } self.key_cache.extend(key_cache); node_id @@ -519,6 +525,10 @@ impl KeyedSlabTree { fn insert_record(&mut self, record: T, parent_id: Option) -> usize { let key = self.extract_key(&record); let node_id = self.tree.insert_record(record, parent_id); + #[cfg(debug_assertions)] + if self.key_cache.contains_key(&key) { + panic!("insert_record: duplicate key {key:?}"); + } self.key_cache.insert(key, node_id); node_id } -- 2.47.3 _______________________________________________ yew-devel mailing list yew-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel