From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A47B51FF16B for ; Fri, 26 Sep 2025 21:29:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EF5717813; Fri, 26 Sep 2025 21:29:49 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Fri, 26 Sep 2025 21:27:08 +0200 Message-ID: <20250926192941.89086-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250926192941.89086-1-s.ivanov@proxmox.com> References: <20250926192941.89086-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758914969105 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [gnu.org] Subject: [pmg-devel] [PATCH package-rebuilds v3 1/2] fetchmail: d/rules: do not skip dh_installinit X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" while removing the init-script and override in d/rules, I skipped dropping dh_installinit from the list of PHONY targets. this resulted in /etc/default/fetchmail not being shipped by our version of fetchmail, thus breaking adding accounts in the PMG GUI (which rewrites /etc/default/fetchmail, and looks for START_DAEMON as marker). debugging this took me quite a bit longer than I wanted - so maybe the short explanation might help a future reader: * the issue was not due to changes in debhelper(7), which I initially thought, nor was it a bug in debhelper. * `dh_installinit` does not expect a 'd/fetchmail.init' file in order to copy 'd/fetchmail.default'. These things can quite well be checked by running `dh binary --no-act -v` - it does list `dh_installinit` right before `dh_tmpfiles`. The core issue is that `.PHONY:` is a make-target and all of it's prerequisites are phony targets[0]. this makes `override_dh_installinit` materialize as target, which is empty, because there are no commands in its recipe. having an empty `override_dh_*` target is the way to tell `dh(1)` to skip a step. [0]https://www.gnu.org/software/make/manual/html_node/Special-Targets.html Fixes: 90b2ccf ("fetchmail: replace sysv init script with systemd units") Signed-off-by: Stoiko Ivanov --- pkgs/fetchmail/fetchmail-6.4.39/debian/rules | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/fetchmail/fetchmail-6.4.39/debian/rules b/pkgs/fetchmail/fetchmail-6.4.39/debian/rules index f0241e5..a56bde5 100755 --- a/pkgs/fetchmail/fetchmail-6.4.39/debian/rules +++ b/pkgs/fetchmail/fetchmail-6.4.39/debian/rules @@ -80,5 +80,4 @@ override_dh_auto_test: dh $@ .PHONY: override_dh_auto_configure override_dh_auto_install \ - override_dh_installinit override_dh_installsystemduser \ - override_dh_auto_test + override_dh_installsystemduser override_dh_auto_test -- 2.47.3 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel