From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9CA081FF183 for ; Wed, 24 Sep 2025 12:36:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D9FE2465; Wed, 24 Sep 2025 12:36:45 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Wed, 24 Sep 2025 12:36:24 +0200 Message-ID: <20250924103625.144589-4-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250924103625.144589-1-s.shaji@proxmox.com> References: <20250924103625.144589-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758710187337 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve_flutter_frontend 3/4] fix: dart-analyze: remove deprecated props and use `RadioGroup` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Starting from flutter v3.32 [0] the `groupValue` and `onChanged` has been deprecated from `RadioListTile` and need to use `RadioGroup` widget. Fixed the issue by wrapping the group of `RadioListTile` widgets with `RadioGroup` [1]. - [0] http://api.flutter.dev/flutter/material/RadioListTile/groupValue.html - [1] https://api.flutter.dev/flutter/widgets/RadioGroup-class.html Signed-off-by: Shan Shaji --- lib/widgets/pve_cd_selector_widget.dart | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/widgets/pve_cd_selector_widget.dart b/lib/widgets/pve_cd_selector_widget.dart index d1f260e..b4591d0 100644 --- a/lib/widgets/pve_cd_selector_widget.dart +++ b/lib/widgets/pve_cd_selector_widget.dart @@ -22,12 +22,13 @@ class PveCdSelector extends StatelessWidget { builder: (context, snapshot) { if (snapshot.hasData) { final state = snapshot.data!; - return Column(children: [ + return RadioGroup( + groupValue: state.value, + onChanged: (value) => cdBloc.events.add(ChangeValue(value)), + child: Column(children: [ RadioListTile( title: const Text('Use CD/DVD disc image file (iso)'), value: CdType.iso, - groupValue: state.value, - onChanged: (value) => cdBloc.events.add(ChangeValue(value)), ), if (state.value == CdType.iso) OutlinedButton( @@ -63,16 +64,12 @@ class PveCdSelector extends StatelessWidget { RadioListTile( title: const Text('Use physical CD/DVD Drive'), value: CdType.cdrom, - groupValue: state.value, - onChanged: (value) => cdBloc.events.add(ChangeValue(value)), ), RadioListTile( title: const Text('Do not use any media'), value: CdType.none, - groupValue: state.value, - onChanged: (value) => cdBloc.events.add(ChangeValue(value)), ), - ]); + ])); } return Container(); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel