From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B094D1FF187 for ; Mon, 22 Sep 2025 21:11:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B35922854; Mon, 22 Sep 2025 21:11:47 +0200 (CEST) Date: Mon, 22 Sep 2025 21:11:40 +0200 From: Stoiko Ivanov To: Fiona Ebner Message-ID: <20250922211140.35d69b25@rosa.proxmox.com> In-Reply-To: <20250918142052.131956-1-f.ebner@proxmox.com> References: <20250918142052.131956-1-f.ebner@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758568288182 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] partially-applied: [PATCH-SERIES pmg-api 0/3] fix #2077: remove dependency on Term::ReadLine X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Thomas applied the pve-common patch - so I went ahead and applied 1/2: e214e9bf ("partially fix #2077: pmgconfig: remove dependency on Term::ReadLine") and 2/2: 3f2ccb1f ("partially fix #2077: pmgcm: remove dependency on Term::ReadLine") Thanks again for the patches! On Thu, 18 Sep 2025 16:19:40 +0200 Fiona Ebner wrote: > As a side-effect, this also fixes #6748. > > Term::ReadLine would prompt and read from terminal even if > stdin/stdout are redirected, the new helper will use the redirected > channels. It also would underline the prompt, which the new helper > does not. And Term::ReadLine also has advanced editing and history > shortcuts. > > For the prompts in pmgconfig and pmgcm, not having the advanced > features is perfectly fine. For pmgsh, which additionally configures > even more features of than mentioned above, the change is rather bad. > > Depends on the following pve-common patch: > https://lore.proxmox.com/pve-devel/20250918135215.95188-2-f.ebner@proxmox.com/ > Dependency bump for pve-common needed. > > > Fiona Ebner (4): > partially fix #2077: pmgconfig: remove dependency on Term::ReadLine > partially fix #2077: pmgcm: remove dependency on Term::ReadLine > partially fix #2077: pmgsh: remove dependency on Term::ReadLine > d/control: remove libterm-readline-gnu-perl dependency > > debian/control | 1 - > src/PMG/CLI/pmgcm.pm | 7 ++----- > src/PMG/CLI/pmgconfig.pm | 19 +++++++------------ > src/bin/pmgsh | 35 ++--------------------------------- > 4 files changed, 11 insertions(+), 51 deletions(-) > _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel