From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BEBF81FF187 for ; Mon, 22 Sep 2025 17:25:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E21531FD8F; Mon, 22 Sep 2025 17:25:51 +0200 (CEST) From: "Max R. Carrara" To: pmg-devel@lists.proxmox.com Date: Mon, 22 Sep 2025 17:24:57 +0200 Message-ID: <20250922152518.550638-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758554706711 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api master v1] config: silence ENOENT when comparing SMTP filter config X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" If `/run/pmg-smtp-filter.cfg` doesn't yet exist when `pmgsync.service` runs, a "No such file or directory" warning is logged. While this has been around since a while [0], the warning might look suspicious to some (as it did to me during testing). Therefore, handle ENOENT separately without emitting any warnings. [0]: https://git.proxmox.com/?p=pmg-api.git;a=commitdiff;h=e5b31a6178118981e784b225941f1502ba644ee5 Signed-off-by: Max R. Carrara --- src/PMG/Config.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm index 44e5463..46e8aa2 100644 --- a/src/PMG/Config.pm +++ b/src/PMG/Config.pm @@ -1909,7 +1909,9 @@ sub compare_smtp_filter_config { my $old; eval { $old = PVE::Tools::file_get_contents($smtp_filter_cfg); }; - if (my $err = $@) { + if ($!{ENOENT}) { + $ret = 1; + } elsif (my $err = $@) { syslog('warning', "reloading pmg-smtp-filter: $err"); $ret = 1; } else { -- 2.47.3 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel