From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C1BB01FF17C for ; Wed, 17 Sep 2025 14:06:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 379EC24AE; Wed, 17 Sep 2025 14:06:56 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Wed, 17 Sep 2025 14:06:16 +0200 Message-ID: <20250917120616.80136-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250917120616.80136-1-s.shaji@proxmox.com> References: <20250917120616.80136-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758110775653 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.145 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox_dart_api_client v2 2/2] fix: ios: add explicit throw of `HandshakeException` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The `cupertino_http` package is throwing `ClientException` [0] instead of `HandShakeException` when the certificate is not valid. Due to this the exception was directly shown in the UI. Inorder to make the error more user friendly catch the `NSErrorClientException` and rethrow `HandShakeException` if the certificate is not valid. Signed-off-by: Shan Shaji --- changes since v1: - Rebased with master lib/src/authenticate.dart | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart index a142a4c..04f363f 100644 --- a/lib/src/authenticate.dart +++ b/lib/src/authenticate.dart @@ -2,12 +2,12 @@ import 'dart:async'; import 'dart:convert'; import 'dart:io'; +import 'package:cupertino_http/cupertino_http.dart'; import 'package:http/http.dart' as http; import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart'; import 'package:proxmox_dart_api_client/src/handle_ticket_response.dart'; import 'package:proxmox_dart_api_client/src/models/serializers.dart'; - /// Returns an authenticated client to work with if successful. /// /// This is the function you are looking for if you want to interact with any @@ -62,6 +62,12 @@ Future authenticate( throw HandshakeException(e.message); } rethrow; + } on NSErrorClientException catch (e) { + // Treat untrusted server certificate (-1202) as a handshake failure. + if (e.error.code == -1202) { + throw HandshakeException(e.message); + } + rethrow; } } @@ -86,5 +92,11 @@ Future> accessDomains( throw HandshakeException(e.message); } rethrow; + } on NSErrorClientException catch (e) { + // Treat untrusted server certificate (-1202) as a handshake failure. + if (e.error.code == -1202) { + throw HandshakeException(e.message); + } + rethrow; } } -- 2.50.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel