From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A1B001FF15E for ; Mon, 15 Sep 2025 11:51:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8F7A1FD12; Mon, 15 Sep 2025 11:52:02 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Mon, 15 Sep 2025 11:51:52 +0200 Message-ID: <20250915095154.78769-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1757929911685 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH network] sdn: remove unused function get_uplink_iface X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Ripgrepped over all my local repos and didn't find an invocation. The last invocation was removed with: 938ebef7bd73 ("vlan/qinq: use bridge option instead uplink-id"). Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN/Zones/Plugin.pm | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm index 0a977fd35a13..6dc2f655ffce 100644 --- a/src/PVE/Network/SDN/Zones/Plugin.pm +++ b/src/PVE/Network/SDN/Zones/Plugin.pm @@ -277,31 +277,6 @@ sub del_bridge_fdb { #helper -sub get_uplink_iface { - my ($interfaces_config, $uplink) = @_; - - my $iface = undef; - foreach my $id (keys %{ $interfaces_config->{ifaces} }) { - my $interface = $interfaces_config->{ifaces}->{$id}; - if (my $iface_uplink = $interface->{'uplink-id'}) { - next if $iface_uplink ne $uplink; - if ($interface->{type} ne 'eth' && $interface->{type} ne 'bond') { - warn "uplink $uplink is not a physical or bond interface"; - next; - } - $iface = $id; - } - } - - #create a dummy uplink interface if no uplink found - if (!$iface) { - warn "can't find uplink $uplink in physical interface"; - $iface = "uplink${uplink}"; - } - - return $iface; -} - sub get_local_route_ip { my ($targetip) = @_; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel