From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 692CC1FF183 for ; Wed, 10 Sep 2025 08:59:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BB5218AD0; Wed, 10 Sep 2025 08:59:31 +0200 (CEST) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Wed, 10 Sep 2025 08:58:29 +0200 Message-ID: <20250910065857.386827-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager] ui: main menu: use initial remote list value from context X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" if the main menu was created after the first update of the remote list, we don't see the changes there as long as the remote list stays the same. So instead of discarding the initial value, use it to update the list here once in create. Reported-by: Wolfgang Bumiller Signed-off-by: Dominik Csapak --- ui/src/main_menu.rs | 45 +++++++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs index 7eac775..d9e8f7c 100644 --- a/ui/src/main_menu.rs +++ b/ui/src/main_menu.rs @@ -109,23 +109,43 @@ fn register_submenu( ); } -impl PdmMainMenu {} +impl PdmMainMenu { + fn update_remote_list(&mut self, remote_list: RemoteList) -> bool { + let remote_list_cache: Vec = remote_list + .into_iter() + .map(|item| RemoteListCacheEntry { + id: item.id.clone(), + ty: item.ty, + }) + .collect(); + + if *self.remote_list_cache != remote_list_cache { + self.remote_list_cache.update(remote_list_cache); + true + } else { + false + } + } +} impl Component for PdmMainMenu { type Message = Msg; type Properties = MainMenu; fn create(ctx: &Context) -> Self { - let (_remote_list, _remote_list_observer) = ctx + let (remote_list, _remote_list_observer) = ctx .link() .context(ctx.link().callback(Msg::RemoteListChanged)) .unwrap_throw(); - Self { + let mut this = Self { active: Key::from("dashboard"), menu_selection: Selection::new(), remote_list_cache: PersistentState::new("PdmRemoteListCache"), _remote_list_observer, - } + }; + + this.update_remote_list(remote_list); + this } fn update(&mut self, _ctx: &Context, msg: Self::Message) -> bool { @@ -134,22 +154,7 @@ impl Component for PdmMainMenu { self.active = key; true } - Msg::RemoteListChanged(remote_list) => { - let remote_list_cache: Vec = remote_list - .into_iter() - .map(|item| RemoteListCacheEntry { - id: item.id.clone(), - ty: item.ty, - }) - .collect(); - - if *self.remote_list_cache != remote_list_cache { - self.remote_list_cache.update(remote_list_cache); - true - } else { - false - } - } + Msg::RemoteListChanged(remote_list) => self.update_remote_list(remote_list), } } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel