From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2E8821FF16F for ; Tue, 2 Sep 2025 12:41:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30548104AA; Tue, 2 Sep 2025 12:41:21 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Tue, 2 Sep 2025 12:41:16 +0200 Message-ID: <20250902104119.110464-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756809665459 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-manager master v1] fix #6747: ceph: osd: swap vg and lv arguments when creating an OSD X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ... specifically when creating logical volumes for OSD DB / WAL devices, if the block device wasn't in use beforehand. The original line was part of a fix for #6652 (92bbc0c89fe) and slipped through during testing. Fixes: #6747 Fixes: 92bbc0c89fe Signed-off-by: Max R. Carrara --- NOTE: Made sure that nothing slipped through this time around, both via the UI and via the CLI. Disks in my test VM: # lsblk /dev/sd{d,e,f} NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINTS sdd 8:48 0 32G 0 disk sde 8:64 0 4G 0 disk sdf 8:80 0 4G 0 disk Created the following OSDs via the CLI: # pveceph osd create /dev/sdd # pveceph osd create /dev/sdd --db_dev /dev/sde --wal_dev /dev/sdf # pveceph osd create /dev/sdd --db_dev /dev/sde # pveceph osd create /dev/sdd --wal_dev /dev/sde ... and ran the following in between: # ceph osd down # ceph osd stop # pveceph osd destroy --cleanup=1 Necessary if creating and destroying a lot of OSDs with the same ID: # systemctl reset-failed This should (hopefully) cover everything. PVE/API2/Ceph/OSD.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 0f850415..a952c952 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -466,7 +466,7 @@ __PACKAGE__->register_method({ my $lv = $type . "-" . UUID::uuid(); PVE::Storage::LVMPlugin::lvm_create_volume_group($dev->{devpath}, $vg); - $osd_lvcreate->($lv, $vg, $size); + $osd_lvcreate->($vg, $lv, $size); if (PVE::Diskmanage::is_partition($dev->{devpath})) { eval { PVE::Diskmanage::change_parttype($dev->{devpath}, '8E00'); }; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel