From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ABD761FF15E for ; Mon, 1 Sep 2025 10:29:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8C4128C3C; Mon, 1 Sep 2025 10:30:08 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 1 Sep 2025 10:29:22 +0200 Message-ID: <20250901082956.40297-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756715391813 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ha: rule edit: fix enabling ha rules which are disabled X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Setting the `disable` property to 0 does not make a HA rule being enabled anymore since a change in the HA Manager, so explicitly delete the `disable` property when the HA rule should be enabled. Reported-by: Friedrich Weber Signed-off-by: Daniel Kral --- www/manager6/ha/RuleEdit.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/ha/RuleEdit.js b/www/manager6/ha/RuleEdit.js index 9ecebd6d..c65c5c97 100644 --- a/www/manager6/ha/RuleEdit.js +++ b/www/manager6/ha/RuleEdit.js @@ -27,7 +27,13 @@ Ext.define('PVE.ha.RuleInputPanel', { values.rule = 'ha-rule-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13); } - values.disable = values.enable ? 0 : 1; + if (values.enable) { + if (!me.isCreate) { + Proxmox.Utils.assemble_field_data(values, { delete: 'disable' }); + } + } else { + values.disable = 1; + } delete values.enable; values.resources = me.formatResourceListString(values.resources); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel