From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E65951FF16B for ; Tue, 26 Aug 2025 16:59:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E90AD3706A; Tue, 26 Aug 2025 16:59:12 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Date: Tue, 26 Aug 2025 16:58:30 +0200 Message-ID: <20250826145836.302748-4-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250826145836.302748-1-s.sterz@proxmox.com> References: <20250826145836.302748-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756220313651 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [icon-sdn.dot, wikimedia.org] Subject: [pve-devel] [PATCH manager 3/9] ui: replace the gif spinner from extjs with an svg X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" the current spinner gif is quite blurry on modern hardware so use an svg based spinner instead. note that by including the css animation in the svg itself, the animation does not appear to restart when extjs re-renders a table. this, at least in firefox 128, lead to jerky looking animation when using font awesome's spinner with the `fa-spin` class. by creating our own svg, we can also make it look more like the extjs version. this does not impact the spinners used by extjs's load mask, as that would require adapting extjs's code itself. Signed-off-by: Shannon Sterz --- www/css/ext6-pve.css | 2 +- www/images/Makefile | 4 +++- www/images/spinner.svg | 24 ++++++++++++++++++++++++ 3 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 www/images/spinner.svg diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 5e77698e9..0b92041df 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -92,7 +92,7 @@ /* loading in task list */ .x-grid-row-loading { background: no-repeat center center; - background-image: url(../ext6/theme-crisp/resources/images/loadmask/loading.gif); + background-image: url(../images/spinner.svg); } /* for font-awesome colors */ diff --git a/www/images/Makefile b/www/images/Makefile index 65ead9789..7c9e12cb0 100644 --- a/www/images/Makefile +++ b/www/images/Makefile @@ -18,6 +18,8 @@ all: # are self made (sources as .xcf) # icon-swap, icon-keyboard, icon-network, icon-usb, icon-cloud # come from fontawesome (respective fa-refresh, fa-keyboard-o, fa-exchange, fa-usb, fa-ellipsis-h, fa-cloud) +# spinner is self made + # icon-serial is a modified version of # https://commons.wikimedia.org/wiki/File:DE9_Diagram.svg # (public domain) @@ -80,7 +82,7 @@ IMAGES = $(GNOME_IMAGES) \ icon-cpu.svg \ icon-memory.svg \ icon-cd-drive.svg \ - + spinner.svg \ icon-sdn.svg: icon-sdn.dot fdp -Tsvg $< > $@ diff --git a/www/images/spinner.svg b/www/images/spinner.svg new file mode 100644 index 000000000..a3fccfc4d --- /dev/null +++ b/www/images/spinner.svg @@ -0,0 +1,24 @@ + + + + + + + + + + + + + + + + + + -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel