From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DC5BB1FF16B for ; Tue, 26 Aug 2025 16:58:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DCD3F36CFD; Tue, 26 Aug 2025 16:58:43 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Date: Tue, 26 Aug 2025 16:58:29 +0200 Message-ID: <20250826145836.302748-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250826145836.302748-1-s.sterz@proxmox.com> References: <20250826145836.302748-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756220313582 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [wikimedia.org] Subject: [pve-devel] [PATCH manager 2/9] ui: remove all occurences of icon-display.png X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" and use the font awesome equivalent instead. this way the icons don't appear blurry and we safe a bit of overhead for storing and loading the png. Signed-off-by: Shannon Sterz --- www/css/ext6-pve.css | 18 ------------------ www/images/Makefile | 5 ++--- www/images/icon-display.png | Bin 221 -> 0 bytes www/manager6/dc/Tasks.js | 6 +++++- www/manager6/grid/PoolMembers.js | 2 +- 5 files changed, 8 insertions(+), 23 deletions(-) delete mode 100644 www/images/icon-display.png diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 356427ead..5e77698e9 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -95,12 +95,6 @@ background-image: url(../ext6/theme-crisp/resources/images/loadmask/loading.gif); } -/* console icon in task list */ -.x-grid-row-console { - background: no-repeat center center; - background-image: url(../images/icon-display.png); -} - /* for font-awesome colors */ /* tree icons */ @@ -299,12 +293,10 @@ .pve-itype-icon-tigervnc, .pve-itype-icon-novnc, .pve-itype-icon-xtermjs, -.pve-itype-icon-display, .pve-itype-icon-network, .pve-itype-icon-network-server, .pve-itype-icon-keyboard, .pve-itype-icon-cdrom, -.pve-itype-icon-qemu, .pve-itype-icon-qemu-template, .pve-itype-icon-qemu-running, .pve-itype-icon-lxc, @@ -341,12 +333,6 @@ font-size: 14px; } -.pve-itype-icon-qemu, -.x-tree-node-computer, -.x-grid-tree-node-expanded .x-tree-node-computer { - background-image: url(../images/icon-display.png); -} - .pve-itype-icon-lxc, .x-tree-node-lxc, .x-grid-tree-node-expanded .x-tree-node-lxc { @@ -391,10 +377,6 @@ background-image: url(../images/icon-cd-drive.svg); } -.pve-itype-icon-display { - background-image: url(../images/icon-display.png); -} - .pve-itype-icon-tigervnc { background-image: url(../images/tigervnc.png); } diff --git a/www/images/Makefile b/www/images/Makefile index 8072d0292..65ead9789 100644 --- a/www/images/Makefile +++ b/www/images/Makefile @@ -16,8 +16,8 @@ all: # icon-cd, icon-pci # are self made (sources as .xcf) -# icon-swap, icon-display, icon-keyboard, icon-network, icon-usb, icon-cloud -# come from fontawesome (respective fa-refresh, fa-desktop, fa-keyboard-o, fa-exchange, fa-usb, fa-ellipsis-h, fa-cloud) +# icon-swap, icon-keyboard, icon-network, icon-usb, icon-cloud +# come from fontawesome (respective fa-refresh, fa-keyboard-o, fa-exchange, fa-usb, fa-ellipsis-h, fa-cloud) # icon-serial is a modified version of # https://commons.wikimedia.org/wiki/File:DE9_Diagram.svg # (public domain) @@ -67,7 +67,6 @@ IMAGES = $(GNOME_IMAGES) \ icon-swap.png \ icon-cd.png \ icon-network.png \ - icon-display.png \ icon-keyboard.png \ logo-ceph.png \ logo-128.png \ diff --git a/www/images/icon-display.png b/www/images/icon-display.png deleted file mode 100644 index 21c50c3293ae8c760dea69bd687937a05a3307c7..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 221 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`Y)RhkE)4%caKYZ?lYt_WJY5_^ zEPCHwHsm^#z|;2d`Fh#V4'; } else { metaData.tdCls = 'x-grid-row-loading'; } return ''; } + return Ext.Date.format(value, 'M d H:i:s'); }, }, diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js index c6e7e9175..83046ee0e 100644 --- a/www/manager6/grid/PoolMembers.js +++ b/www/manager6/grid/PoolMembers.js @@ -243,7 +243,7 @@ Ext.define('PVE.grid.PoolMembers', { items: [ { text: gettext('Virtual Machine'), - iconCls: 'pve-itype-icon-qemu', + iconCls: 'fa fa-desktop', handler: function () { var win = Ext.create('PVE.pool.AddVM', { pool: me.pool }); win.on('destroy', reload); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel